Skip to content

Commit

Permalink
šŸ› [amp-story-audio-sticker] make grid layer mandatory ancestor, not pā€¦
Browse files Browse the repository at this point in the history
ā€¦arent (ampproject#39727)

* [amp-story-audio-sticker] make grid layer mandatory ancestor, not parent

* Update out file
  • Loading branch information
swissspidy authored and eszponder committed Apr 22, 2024
1 parent 31b04e8 commit 8ac233d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ FAIL
| <amp-story-page id="page-1" title="Lorem ipsum dolor sit amet">
| <amp-story-audio-sticker sticker="audio-cloud"></amp-story-audio-sticker>
>> ^~~~~~~~~
amp-story-audio-sticker/0.1/test/validator-amp-story-audio-sticker-no-grid-layer.html:22:8 The parent tag of tag 'amp-story-audio-sticker' is 'amp-story-page', but it can only be 'amp-story-grid-layer'. (see https://amp.dev/documentation/components/amp-story-audio-sticker)
amp-story-audio-sticker/0.1/test/validator-amp-story-audio-sticker-no-grid-layer.html:22:8 The tag 'amp-story-audio-sticker' may only appear as a descendant of tag 'amp-story-grid-layer'. (see https://amp.dev/documentation/components/amp-story-audio-sticker)
>> ^~~~~~~~~
amp-story-audio-sticker/0.1/test/validator-amp-story-audio-sticker-no-grid-layer.html:22:8 Tag 'amp-story-audio-sticker' is disallowed as child of tag 'amp-story-page'. Child tag must be one of ['amp-analytics', 'amp-pixel', 'amp-story-animation', 'amp-story-auto-analytics', 'amp-story-cta-layer', 'amp-story-grid-layer', 'amp-story-page-attachment', 'amp-story-page-outlink', 'amp-story-shopping-attachment']. (see https://amp.dev/documentation/components/amp-story)
| </amp-story-page>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ tags: { # <amp-story-audio-sticker>
html_format: AMP
tag_name: "AMP-STORY-AUDIO-STICKER"
requires_extension: "amp-story-audio-sticker"
mandatory_parent: "AMP-STORY-GRID-LAYER"
mandatory_ancestor: "AMP-STORY-GRID-LAYER"
attr_lists: "extended-amp-global"
amp_layout: {
supported_layouts: CONTAINER
Expand Down Expand Up @@ -62,4 +62,4 @@ descendant_tag_list: {
tag: "AMP-IMG"
tag: "DIV"
tag: "SPAN"
}
}

0 comments on commit 8ac233d

Please sign in to comment.