From ef2a622d3e9d268ba33790d2638c8765584b2c7d Mon Sep 17 00:00:00 2001 From: Eugeniy Medvedev Date: Mon, 11 Sep 2023 09:31:49 +0200 Subject: [PATCH 1/3] Change default DNS 9.9.9.9 to 9.9.9.10 --- kube.tf.example | 2 +- variables.tf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kube.tf.example b/kube.tf.example index 87758a42..81c6f63e 100644 --- a/kube.tf.example +++ b/kube.tf.example @@ -564,7 +564,7 @@ module "kube-hetzner" { # You can enable cert-manager (installed by Helm behind the scenes) with the following flag, the default is "true". # enable_cert_manager = false - # IP Addresses to use for the DNS Servers, set to an empty list to use the ones provided by Hetzner, defaults to ["1.1.1.1", "8.8.8.8", "9.9.9.9"]. + # IP Addresses to use for the DNS Servers, set to an empty list to use the ones provided by Hetzner, defaults to ["1.1.1.1", "8.8.8.8", "9.9.9.10"]. # The number of different DNS servers is limited to 3 by Kubernetes itself. # dns_servers = [] diff --git a/variables.tf b/variables.tf index 5cad5437..d9b2a583 100644 --- a/variables.tf +++ b/variables.tf @@ -679,7 +679,7 @@ variable "control_plane_lb_enable_public_interface" { variable "dns_servers" { type = list(string) - default = ["1.1.1.1", "8.8.8.8", "9.9.9.9"] + default = ["1.1.1.1", "8.8.8.8", "9.9.9.10"] description = "IP Addresses to use for the DNS Servers, set to an empty list to use the ones provided by Hetzner. The length is limited to 3 entries, more entries is not supported by kubernetes" validation { From 1f44821d9b17036d5dff088d135063c042af0db7 Mon Sep 17 00:00:00 2001 From: Eugeniy Medvedev Date: Mon, 11 Sep 2023 14:33:06 +0200 Subject: [PATCH 2/3] Use default Hetzner DNS --- README.md | 2 ++ docs/terraform.md | 4 ++-- kube.tf.example | 4 ++-- variables.tf | 2 +- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 2e6a794b..62e24932 100644 --- a/README.md +++ b/README.md @@ -866,6 +866,8 @@ Code contributions are very much **welcome**. packer build ../kube-hetzner/packer-template/hcloud-microos-snapshots.pkr.hcl ``` +1. Update examples in `kube.tf.example` if required. +1. Run [terraform-docs](https://github.com/terraform-docs/terraform-docs) generator `docker run --rm --volume "$(pwd):/terraform-docs" -u $(id -u) quay.io/terraform-docs/terraform-docs:0.16.0 markdown /terraform-docs > docs/terraform.md` if you changed default variables. 1. Commit your Changes (`git commit -m 'Add some AmazingFeature') 1. Push to the Branch (`git push origin AmazingFeature`) 1. Open a Pull Request targeting the `staging` branch. diff --git a/docs/terraform.md b/docs/terraform.md index 2e66aaa4..8e2e1b67 100644 --- a/docs/terraform.md +++ b/docs/terraform.md @@ -115,7 +115,7 @@ | [csi\_driver\_smb\_values](#input\_csi\_driver\_smb\_values) | Additional helm values file to pass to csi-driver-smb as 'valuesContent' at the HelmChart. | `string` | `""` | no | | [disable\_hetzner\_csi](#input\_disable\_hetzner\_csi) | Disable hetzner csi driver. | `bool` | `false` | no | | [disable\_network\_policy](#input\_disable\_network\_policy) | Disable k3s default network policy controller (default false, automatically true for calico and cilium). | `bool` | `false` | no | -| [dns\_servers](#input\_dns\_servers) | IP Addresses to use for the DNS Servers, set to an empty list to use the ones provided by Hetzner. The length is limited to 3 entries, more entries is not supported by kubernetes | `list(string)` | 
[
  "1.1.1.1",
  "8.8.8.8",
  "9.9.9.9"
]
| no | +| [dns\_servers](#input\_dns\_servers) | IP Addresses to use for the DNS Servers, set to an empty list to use the ones provided by Hetzner. The length is limited to 3 entries, more entries is not supported by kubernetes | `list(string)` | `[]` | no | | [enable\_cert\_manager](#input\_enable\_cert\_manager) | Enable cert manager. | `bool` | `true` | no | | [enable\_csi\_driver\_smb](#input\_enable\_csi\_driver\_smb) | Whether or not to enable csi-driver-smb. | `bool` | `false` | no | | [enable\_klipper\_metal\_lb](#input\_enable\_klipper\_metal\_lb) | Use klipper load balancer. | `bool` | `false` | no | @@ -204,4 +204,4 @@ | [kubeconfig\_file](#output\_kubeconfig\_file) | Kubeconfig file content with external IP address | | [network\_id](#output\_network\_id) | The ID of the HCloud network. | | [ssh\_key\_id](#output\_ssh\_key\_id) | The ID of the HCloud SSH key. | - + \ No newline at end of file diff --git a/kube.tf.example b/kube.tf.example index 81c6f63e..f8ef7cdd 100644 --- a/kube.tf.example +++ b/kube.tf.example @@ -564,9 +564,9 @@ module "kube-hetzner" { # You can enable cert-manager (installed by Helm behind the scenes) with the following flag, the default is "true". # enable_cert_manager = false - # IP Addresses to use for the DNS Servers, set to an empty list to use the ones provided by Hetzner, defaults to ["1.1.1.1", "8.8.8.8", "9.9.9.10"]. + # IP Addresses to use for the DNS Servers, set to an empty list to use the ones provided by Hetzner https://docs.hetzner.com/dns-console/dns/general/recursive-name-servers/, (defaults is []). # The number of different DNS servers is limited to 3 by Kubernetes itself. - # dns_servers = [] + # dns_servers = ["1.1.1.1", "8.8.8.8", "9.9.9.10"] # When this is enabled, rather than the first node, all external traffic will be routed via a control-plane loadbalancer, allowing for high availability. # The default is false. diff --git a/variables.tf b/variables.tf index d9b2a583..8494ddff 100644 --- a/variables.tf +++ b/variables.tf @@ -679,7 +679,7 @@ variable "control_plane_lb_enable_public_interface" { variable "dns_servers" { type = list(string) - default = ["1.1.1.1", "8.8.8.8", "9.9.9.10"] + default = [] description = "IP Addresses to use for the DNS Servers, set to an empty list to use the ones provided by Hetzner. The length is limited to 3 entries, more entries is not supported by kubernetes" validation { From 3919312b6302d16c93f7bc2df9d5a3a08cf8da2a Mon Sep 17 00:00:00 2001 From: Eugeniy Medvedev Date: Mon, 11 Sep 2023 16:11:18 +0200 Subject: [PATCH 3/3] Fix Readme --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 62e24932..cc18fc64 100644 --- a/README.md +++ b/README.md @@ -867,7 +867,6 @@ Code contributions are very much **welcome**. ``` 1. Update examples in `kube.tf.example` if required. -1. Run [terraform-docs](https://github.com/terraform-docs/terraform-docs) generator `docker run --rm --volume "$(pwd):/terraform-docs" -u $(id -u) quay.io/terraform-docs/terraform-docs:0.16.0 markdown /terraform-docs > docs/terraform.md` if you changed default variables. 1. Commit your Changes (`git commit -m 'Add some AmazingFeature') 1. Push to the Branch (`git push origin AmazingFeature`) 1. Open a Pull Request targeting the `staging` branch.