-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump k8s-openapi to 0.20.0 #1291
Conversation
Also bumps minimum kubernetes version. Signed-off-by: clux <sszynrae@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1291 +/- ##
=======================================
Coverage ? 72.31%
=======================================
Files ? 75
Lines ? 6347
Branches ? 0
=======================================
Hits ? 4590
Misses ? 1757
Partials ? 0 |
Signed-off-by: Eirik A <sszynrae@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM. Might be worth including a note about Arnavion/k8s-openapi#149 in the release notes.
Ah, yes, will add. |
Out of curiosity, for all the places where you updated the k8s-openapi feature If you're worried about |
Ah, yes. Actually just hadn't gotten around to do it yet. I did just update the recommendation in our docs yesterday to tell people to use Still, nice to clear all that up. Will put up a PR to update it to By the way, the Do you have strong feelings about supporting this extended range? It could make k8s-openapi a little more lightweight to drop one. We reasoned that it made sense to follow upstream EOL cycles as per our current https://kube.rs/kubernetes-version/#policy - but if you are not keen on that, we could alternatively increase our range instead. |
My policy is to support the oldest one that public clouds support, per https://github.com/Arnavion/k8s-openapi/blob/master/CONTRIBUTING.md#cloud-offerings . ACK tends to be the oldest one. |
In practice, that looks like it gives you sometimes 7 versions supported, and sometimes 8. At the very least, it would be good to have a consistent answer. (ACK running 1.22 a full 10 months after upstream maintenance was dropped is an interesting choice - but i guess all cloud providers lag behind upstream support here to some extent (EDIT: looks like Kubernetes gave ~2mo extra leeway to backport CVE fixes so only 8mo but still..)) |
Also bumps minimum kubernetes version.
Standard
just bump-k8s
pluscargo upgrade -p k8s-openapi -i
and the few readme updates.Last one before release.