Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s-openapi to 0.20.0 #1291

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Bump k8s-openapi to 0.20.0 #1291

merged 2 commits into from
Sep 8, 2023

Conversation

clux
Copy link
Member

@clux clux commented Sep 7, 2023

Also bumps minimum kubernetes version.
Standard just bump-k8s plus cargo upgrade -p k8s-openapi -i and the few readme updates.

Last one before release.

Also bumps minimum kubernetes version.

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux added the changelog-change changelog change category for prs label Sep 7, 2023
@clux clux added this to the 0.86.0 milestone Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@3d68ec1). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1291   +/-   ##
=======================================
  Coverage        ?   72.31%           
=======================================
  Files           ?       75           
  Lines           ?     6347           
  Branches        ?        0           
=======================================
  Hits            ?     4590           
  Misses          ?     1757           
  Partials        ?        0           
📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kube-rs).

@clux clux requested a review from a team September 8, 2023 09:16
Signed-off-by: Eirik A <sszynrae@gmail.com>
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. Might be worth including a note about Arnavion/k8s-openapi#149 in the release notes.

@clux
Copy link
Member Author

clux commented Sep 8, 2023

Ah, yes, will add.

@clux clux merged commit 0d935be into main Sep 8, 2023
17 checks passed
@clux clux deleted the openapi020 branch September 8, 2023 09:33
@Arnavion
Copy link

Out of curiosity, for all the places where you updated the k8s-openapi feature v1_27 to v1_28, why don't you use latest ?

If you're worried about latest updating to a different version in a semver-compatible update, that won't happen, because adding (or removing) supported versions is always a semver-incompatible change. Not only could that break anyone using latest, but also it could break anyone using the version macros.

@clux
Copy link
Member Author

clux commented Sep 10, 2023

Ah, yes. Actually just hadn't gotten around to do it yet. I did just update the recommendation in our docs yesterday to tell people to use latest. And there was also some automation for it in the justfile to bump so it has not been a hard job.

Still, nice to clear all that up. Will put up a PR to update it to latest as that side is a pretty clear improvement.

By the way, the earliest alias is also very nice, and could be very helpful for the other side of the range (for testing our minimum supported version), but we are slightly misaligned on our policies (we have currently settled on a 6 version range, and you have 7 - so our MSRV is always +1 of earliest atm). It's probably a bit surprising to folks that we deviate.

Do you have strong feelings about supporting this extended range? It could make k8s-openapi a little more lightweight to drop one. We reasoned that it made sense to follow upstream EOL cycles as per our current https://kube.rs/kubernetes-version/#policy - but if you are not keen on that, we could alternatively increase our range instead.

@Arnavion
Copy link

My policy is to support the oldest one that public clouds support, per https://github.com/Arnavion/k8s-openapi/blob/master/CONTRIBUTING.md#cloud-offerings . ACK tends to be the oldest one.

@clux
Copy link
Member Author

clux commented Sep 10, 2023

In practice, that looks like it gives you sometimes 7 versions supported, and sometimes 8. At the very least, it would be good to have a consistent answer.

(ACK running 1.22 a full 10 months after upstream maintenance was dropped is an interesting choice - but i guess all cloud providers lag behind upstream support here to some extent (EDIT: looks like Kubernetes gave ~2mo extra leeway to backport CVE fixes so only 8mo but still..))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-change changelog change category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants