Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change explicit v1_28 feature to use latest feature alias #1292

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Conversation

clux
Copy link
Member

@clux clux commented Sep 10, 2023

Simplify our build setup to always set our MAX as the latest version k8s-openapi exposes.

This doesn't let us avoid all the automation to bump (still need an explicit version for k3d on CI for the minimum check), but it avoids having to bump all the readme and toml files for the latest dev-deps.

Brought up in #1291 (comment)

Have updated recommendations in https://kube.rs/kubernetes-version/ to more explicitly tell users to use latest unless they have a reason for it (before we where a bit vague about it - but now it's easier with the feature alias).

…8s-openapi`

Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux added the changelog-exclude changelog excluded prs label Sep 10, 2023
@clux clux added this to the 0.87.0 milestone Sep 10, 2023
@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Merging #1292 (c4441bb) into main (044cac4) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1292      +/-   ##
==========================================
- Coverage   72.31%   72.30%   -0.02%     
==========================================
  Files          75       75              
  Lines        6347     6347              
==========================================
- Hits         4590     4589       -1     
- Misses       1757     1758       +1     

see 1 file with indirect coverage changes

@clux clux requested a review from a team September 11, 2023 17:45
@clux clux merged commit 5e3d1cd into main Sep 11, 2023
17 checks passed
@clux clux deleted the use-latest branch September 11, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants