Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc cleanup for label selectors #1542

Merged
merged 3 commits into from
Jul 20, 2024
Merged

Doc cleanup for label selectors #1542

merged 3 commits into from
Jul 20, 2024

Conversation

clux
Copy link
Member

@clux clux commented Jul 20, 2024

Mostly a quick overview to make it as concise as possible.

The original was already very nice, just broke up paragraphs, imports, and added missing strings where they were needed on UI.

clux added 2 commits July 20, 2024 15:52
Mostly a quick overview to make it as concise as possible.

The original was already very nice, just broke up paragraphs, imports, and added missing strings where they were needed on UI.

Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux added the changelog-exclude changelog excluded prs label Jul 20, 2024
@clux clux added this to the 0.93.0 milestone Jul 20, 2024
Signed-off-by: clux <sszynrae@gmail.com>
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.7%. Comparing base (1816fd8) to head (e8cf63e).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1542   +/-   ##
=====================================
  Coverage   75.7%   75.7%           
=====================================
  Files         79      79           
  Lines       7252    7252           
=====================================
  Hits        5487    5487           
  Misses      1765    1765           
Files Coverage Δ
kube-core/src/labels.rs 90.3% <ø> (ø)
kube-core/src/params.rs 85.6% <ø> (ø)
kube-derive/src/lib.rs 0.0% <ø> (ø)

@clux clux marked this pull request as ready for review July 20, 2024 15:09
@clux
Copy link
Member Author

clux commented Jul 20, 2024

Sending this one through without ceremony as it's only docs.

@clux clux merged commit 2fe7219 into main Jul 20, 2024
18 checks passed
@clux clux deleted the doc-cleanup-labels branch July 20, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant