-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward Correct Status Code in KFAM API #28
Comments
Bumping this for visibility. Debugging the Kubeflow Access Management component would be much easier if the appropriate error codes were used depending on err values instead of returning a blanket 403 when that is indeed incorrect. |
/transfer dashboard |
@Collinbrown95: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/kind feature
CC: @Souheil-Yazji @mathis-marcotte
Why you need this feature:
The current implementation off the KFAM API has several endpoints where any error is assumed to be
403 Forbidden
. E.g.ReadBinding
.Describe the solution you'd like:
Perhaps we could forward along the http response directly by using something like
err.ErrStatus.Code
instead of hard-codinghttp.StatusForbidden
.Anything else you would like to add:
Ideally, it would be helpful to add some additional debug logs to some of these messages to facilitate debugging. My team has a use case where we are getting occasional errors that are incorrectly reported as
403 Forbidden
with very little additional information to help debug. It would be helpful if we could set the log level todebug
instead of the default log level and get more detail about the error message.The text was updated successfully, but these errors were encountered: