Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request join to Kubeflow org #583

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Conversation

kuizhiqing
Copy link
Member

Plz consider my request for continuing support.

Plz consider my request for continuing support.
@google-oss-prow
Copy link

Hi @kuizhiqing. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kuizhiqing
Copy link
Member Author

@johnugeorge plz help with this, thx.

@johnugeorge
Copy link
Member

+1
@kuizhiqing has added Paddlepaddle support to training operator kubeflow/training-operator#1675 and kubeflow/website#3388

Thanks for all contributions

/lgtm

@johnugeorge
Copy link
Member

/lgtm cancel

Can you remove the entry from wg-training leads section ? You have to add as an reviewer in https://github.com/kubeflow/training-operator/blob/master/OWNERS

@google-oss-prow google-oss-prow bot removed the lgtm label Nov 8, 2022
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to add as a member. Please address @johnugeorge's comment above

@kuizhiqing
Copy link
Member Author

Done.
Thanks @johnugeorge @terrytangyuan

@johnugeorge
Copy link
Member

/assign @zijianjoy

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chensun
Copy link
Member

chensun commented Nov 17, 2022

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, kuizhiqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Nov 17, 2022
@google-oss-prow google-oss-prow bot merged commit 8677af7 into kubeflow:master Nov 17, 2022
@kuizhiqing kuizhiqing deleted the patch-1 branch November 18, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants