From 41b24441e1a2e7219b4199c542ae6d542e7082cb Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Mon, 22 Jul 2024 11:12:17 +0530 Subject: [PATCH 1/4] create seperate file for install_KinD_create_KinD_cluster_install_kustomize.sh to avoid code repitition Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> --- .github/workflows/admission_webhook_test.yaml | 14 ++------- ...D_create_KinD_cluster_install_kustomize.sh | 29 +++++++++++++++++++ 2 files changed, 32 insertions(+), 11 deletions(-) create mode 100644 tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh diff --git a/.github/workflows/admission_webhook_test.yaml b/.github/workflows/admission_webhook_test.yaml index 3a4d8e04af..6d55a6ddc0 100644 --- a/.github/workflows/admission_webhook_test.yaml +++ b/.github/workflows/admission_webhook_test.yaml @@ -4,9 +4,7 @@ on: paths: - .github/workflows/admission_webhook_test.yaml - apps/admission-webhook/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - tests/gh-actions/install_istio.sh - tests/gh-actions/install_cert_manager.sh - common/cert-manager/** @@ -18,14 +16,8 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh b/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh new file mode 100644 index 0000000000..81f5e559ce --- /dev/null +++ b/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh @@ -0,0 +1,29 @@ +#!/bin/bash + +set -e + +# Function to handle errors +handle_error() { + echo "Error: $1" + exit 1 +} + +# Install KinD +echo "Installing KinD..." +if ! ./tests/gh-actions/install_kind.sh; then + handle_error "Failed to install KinD" +fi + +# Create KinD Cluster +echo "Creating KinD Cluster..." +if ! kind create cluster --config tests/gh-actions/kind-cluster.yaml; then + handle_error "Failed to create KinD cluster" +fi + +# Install kustomize +echo "Installing kustomize..." +if ! ./tests/gh-actions/install_kustomize.sh; then + handle_error "Failed to install kustomize" +fi + +echo "All steps completed successfully." From d1d565661f778369d7ce380329d2b86781421c23 Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Mon, 22 Jul 2024 11:21:29 +0530 Subject: [PATCH 2/4] make sh file executable Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> --- .github/workflows/admission_webhook_test.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/admission_webhook_test.yaml b/.github/workflows/admission_webhook_test.yaml index 6d55a6ddc0..9dcfe3da83 100644 --- a/.github/workflows/admission_webhook_test.yaml +++ b/.github/workflows/admission_webhook_test.yaml @@ -17,7 +17,9 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh From 77bfdccd8b1c246f29d8ae4f30b616df9f105fad Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Tue, 30 Jul 2024 14:59:02 +0530 Subject: [PATCH 3/4] Made chnages in workflow files to remove reduntant codes Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> --- .github/workflows/bentoml_test.yaml | 12 ++++-------- .github/workflows/centraldashboard_test.yaml | 12 ++++-------- .github/workflows/dex_test.yaml | 12 ++++-------- .../workflows/jupyter_web_application_test.yaml | 12 ++++-------- .github/workflows/katib_test.yaml | 12 ++++-------- .github/workflows/kserve_cni_test.yaml | 12 ++++-------- .github/workflows/kserve_m2m_test.yaml | 12 ++++-------- .github/workflows/kserve_test.yaml | 12 ++++-------- .github/workflows/metacontroller_test.yaml | 12 ++++-------- .github/workflows/model_registry_test.yaml | 12 ++++-------- .../workflows/notebook_controller_m2m_test.yaml | 14 +++++--------- .github/workflows/notebook_controller_test.yaml | 12 ++++-------- .github/workflows/pipeline_run_from_notebook.yaml | 12 ++++-------- .github/workflows/pipeline_test.yaml | 12 ++++-------- .github/workflows/profiles_test.yaml | 12 ++++-------- .github/workflows/ray_test.yaml | 12 ++++-------- .github/workflows/seldon_test.yaml | 12 ++++-------- .github/workflows/tensorboard_controller_test.yaml | 12 ++++-------- .../tensorboards_web_application_test.yaml | 12 ++++-------- .github/workflows/train_operator_test.yaml | 12 ++++-------- .../workflows/volumes_web_application_test.yaml | 12 ++++-------- 21 files changed, 85 insertions(+), 169 deletions(-) diff --git a/.github/workflows/bentoml_test.yaml b/.github/workflows/bentoml_test.yaml index 71b59956ff..b75b15e2ea 100644 --- a/.github/workflows/bentoml_test.yaml +++ b/.github/workflows/bentoml_test.yaml @@ -17,14 +17,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install cert-manager run: ./tests/gh-actions/install_cert_manager.sh diff --git a/.github/workflows/centraldashboard_test.yaml b/.github/workflows/centraldashboard_test.yaml index 6fd9337da1..ec86d67840 100644 --- a/.github/workflows/centraldashboard_test.yaml +++ b/.github/workflows/centraldashboard_test.yaml @@ -16,14 +16,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/dex_test.yaml b/.github/workflows/dex_test.yaml index 140772cf79..500153611d 100644 --- a/.github/workflows/dex_test.yaml +++ b/.github/workflows/dex_test.yaml @@ -16,14 +16,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/jupyter_web_application_test.yaml b/.github/workflows/jupyter_web_application_test.yaml index 6cd555d8f9..2de83055a0 100644 --- a/.github/workflows/jupyter_web_application_test.yaml +++ b/.github/workflows/jupyter_web_application_test.yaml @@ -16,14 +16,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/katib_test.yaml b/.github/workflows/katib_test.yaml index c61e2237b3..e097700fa9 100644 --- a/.github/workflows/katib_test.yaml +++ b/.github/workflows/katib_test.yaml @@ -18,14 +18,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/kserve_cni_test.yaml b/.github/workflows/kserve_cni_test.yaml index eb48f8fb34..6604bf2901 100644 --- a/.github/workflows/kserve_cni_test.yaml +++ b/.github/workflows/kserve_cni_test.yaml @@ -20,14 +20,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Create kubeflow namespace run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - diff --git a/.github/workflows/kserve_m2m_test.yaml b/.github/workflows/kserve_m2m_test.yaml index f1b484af4f..dfe9cfc9b0 100644 --- a/.github/workflows/kserve_m2m_test.yaml +++ b/.github/workflows/kserve_m2m_test.yaml @@ -23,18 +23,14 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install kubectl run: ./tests/gh-actions/install_kubectl.sh - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh - - name: Create kubeflow namespace run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - diff --git a/.github/workflows/kserve_test.yaml b/.github/workflows/kserve_test.yaml index e4d5ef7cfe..36f86abae1 100644 --- a/.github/workflows/kserve_test.yaml +++ b/.github/workflows/kserve_test.yaml @@ -20,14 +20,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Create kubeflow namespace run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - diff --git a/.github/workflows/metacontroller_test.yaml b/.github/workflows/metacontroller_test.yaml index 403c126aa1..23abd8d4e8 100644 --- a/.github/workflows/metacontroller_test.yaml +++ b/.github/workflows/metacontroller_test.yaml @@ -19,14 +19,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config ./tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/model_registry_test.yaml b/.github/workflows/model_registry_test.yaml index b8f3ad847b..4ac7415672 100644 --- a/.github/workflows/model_registry_test.yaml +++ b/.github/workflows/model_registry_test.yaml @@ -17,18 +17,14 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install kubectl run: ./tests/gh-actions/install_kubectl.sh - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh - - name: Create kubeflow namespace run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - diff --git a/.github/workflows/notebook_controller_m2m_test.yaml b/.github/workflows/notebook_controller_m2m_test.yaml index 5a3688b039..c8d07bc74f 100644 --- a/.github/workflows/notebook_controller_m2m_test.yaml +++ b/.github/workflows/notebook_controller_m2m_test.yaml @@ -19,18 +19,14 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + - name: Install kubectl run: ./tests/gh-actions/install_kubectl.sh - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh - - name: Create kubeflow namespace run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - diff --git a/.github/workflows/notebook_controller_test.yaml b/.github/workflows/notebook_controller_test.yaml index abb01afaf0..5866e40184 100644 --- a/.github/workflows/notebook_controller_test.yaml +++ b/.github/workflows/notebook_controller_test.yaml @@ -17,14 +17,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/pipeline_run_from_notebook.yaml b/.github/workflows/pipeline_run_from_notebook.yaml index 52c80bd021..614c328501 100644 --- a/.github/workflows/pipeline_run_from_notebook.yaml +++ b/.github/workflows/pipeline_run_from_notebook.yaml @@ -23,14 +23,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio with ext auth run: ./tests/gh-actions/install_istio_with_ext_auth.sh diff --git a/.github/workflows/pipeline_test.yaml b/.github/workflows/pipeline_test.yaml index 0fbf4b3e21..46199964c4 100644 --- a/.github/workflows/pipeline_test.yaml +++ b/.github/workflows/pipeline_test.yaml @@ -21,14 +21,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install kubectl run: ./tests/gh-actions/install_kubectl.sh diff --git a/.github/workflows/profiles_test.yaml b/.github/workflows/profiles_test.yaml index 2352352bf9..bbf466ca05 100644 --- a/.github/workflows/profiles_test.yaml +++ b/.github/workflows/profiles_test.yaml @@ -17,14 +17,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/ray_test.yaml b/.github/workflows/ray_test.yaml index 56732ddbc6..adc08594c0 100644 --- a/.github/workflows/ray_test.yaml +++ b/.github/workflows/ray_test.yaml @@ -14,14 +14,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Build & Apply manifests run: | diff --git a/.github/workflows/seldon_test.yaml b/.github/workflows/seldon_test.yaml index 822ba29df4..3a2f78e6a9 100644 --- a/.github/workflows/seldon_test.yaml +++ b/.github/workflows/seldon_test.yaml @@ -19,14 +19,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/tensorboard_controller_test.yaml b/.github/workflows/tensorboard_controller_test.yaml index 9e1104fce7..d73fb302f4 100644 --- a/.github/workflows/tensorboard_controller_test.yaml +++ b/.github/workflows/tensorboard_controller_test.yaml @@ -17,14 +17,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/tensorboards_web_application_test.yaml b/.github/workflows/tensorboards_web_application_test.yaml index b74640325b..c18c198557 100644 --- a/.github/workflows/tensorboards_web_application_test.yaml +++ b/.github/workflows/tensorboards_web_application_test.yaml @@ -17,14 +17,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/train_operator_test.yaml b/.github/workflows/train_operator_test.yaml index 23d891f627..bd95fe826a 100644 --- a/.github/workflows/train_operator_test.yaml +++ b/.github/workflows/train_operator_test.yaml @@ -18,14 +18,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/volumes_web_application_test.yaml b/.github/workflows/volumes_web_application_test.yaml index ee832b0aab..8e2a53e560 100644 --- a/.github/workflows/volumes_web_application_test.yaml +++ b/.github/workflows/volumes_web_application_test.yaml @@ -17,14 +17,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh From 9fc854b0eec509bca08474c64c01bd3eb517dbb3 Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Tue, 30 Jul 2024 15:05:42 +0530 Subject: [PATCH 4/4] remove unnecessary code from test yaml files Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> --- .github/workflows/bentoml_test.yaml | 3 --- .github/workflows/centraldashboard_test.yaml | 3 --- .github/workflows/dex_test.yaml | 3 --- .github/workflows/jupyter_web_application_test.yaml | 3 --- .github/workflows/katib_test.yaml | 3 --- .github/workflows/kserve_cni_test.yaml | 3 --- .github/workflows/kserve_m2m_test.yaml | 3 --- .github/workflows/kserve_test.yaml | 3 --- .github/workflows/metacontroller_test.yaml | 3 --- .github/workflows/model_registry_test.yaml | 2 -- .github/workflows/notebook_controller_m2m_test.yaml | 3 --- .github/workflows/notebook_controller_test.yaml | 3 --- .github/workflows/pipeline_run_from_notebook.yaml | 3 --- .github/workflows/pipeline_test.yaml | 3 --- .github/workflows/profiles_test.yaml | 3 --- .github/workflows/ray_test.yaml | 2 -- .github/workflows/seldon_test.yaml | 3 --- .github/workflows/tensorboard_controller_test.yaml | 3 --- .github/workflows/tensorboards_web_application_test.yaml | 3 --- .github/workflows/train_operator_test.yaml | 3 --- .github/workflows/volumes_web_application_test.yaml | 3 --- 21 files changed, 61 deletions(-) diff --git a/.github/workflows/bentoml_test.yaml b/.github/workflows/bentoml_test.yaml index b75b15e2ea..dade029127 100644 --- a/.github/workflows/bentoml_test.yaml +++ b/.github/workflows/bentoml_test.yaml @@ -3,9 +3,6 @@ on: pull_request: paths: - .github/workflows/bentoml_test.yaml - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - tests/gh-actions/install_cert_manager.sh - common/cert-manager/** - contrib/bentoml/** diff --git a/.github/workflows/centraldashboard_test.yaml b/.github/workflows/centraldashboard_test.yaml index ec86d67840..691d13a6a2 100644 --- a/.github/workflows/centraldashboard_test.yaml +++ b/.github/workflows/centraldashboard_test.yaml @@ -4,9 +4,6 @@ on: paths: - .github/workflows/centraldashboard_test.yaml - apps/centraldashboard/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - tests/gh-actions/install_istio.sh jobs: diff --git a/.github/workflows/dex_test.yaml b/.github/workflows/dex_test.yaml index 500153611d..db1d5b322f 100644 --- a/.github/workflows/dex_test.yaml +++ b/.github/workflows/dex_test.yaml @@ -4,9 +4,6 @@ on: paths: - .github/workflows/dex_test.yaml - common/dex/base/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - tests/gh-actions/install_istio.sh jobs: diff --git a/.github/workflows/jupyter_web_application_test.yaml b/.github/workflows/jupyter_web_application_test.yaml index 2de83055a0..f01d5c717c 100644 --- a/.github/workflows/jupyter_web_application_test.yaml +++ b/.github/workflows/jupyter_web_application_test.yaml @@ -4,9 +4,6 @@ on: paths: - .github/workflows/jupyter_web_application_test.yaml - apps/jupyter/jupyter-web-app/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - tests/gh-actions/install_istio.sh jobs: diff --git a/.github/workflows/katib_test.yaml b/.github/workflows/katib_test.yaml index e097700fa9..299b768dab 100644 --- a/.github/workflows/katib_test.yaml +++ b/.github/workflows/katib_test.yaml @@ -4,9 +4,6 @@ on: paths: - .github/workflows/katib_test.yaml - apps/katib/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - tests/gh-actions/install_istio.sh - tests/gh-actions/install_cert_manager.sh - common/cert-manager/** diff --git a/.github/workflows/kserve_cni_test.yaml b/.github/workflows/kserve_cni_test.yaml index 6604bf2901..a062e06ef8 100644 --- a/.github/workflows/kserve_cni_test.yaml +++ b/.github/workflows/kserve_cni_test.yaml @@ -3,9 +3,6 @@ on: pull_request: paths: - .github/workflows/kserve_cni_test.yaml - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - common/istio-cni-1-22/** - tests/gh-actions/install_cert_manager.sh - common/cert-manager/** diff --git a/.github/workflows/kserve_m2m_test.yaml b/.github/workflows/kserve_m2m_test.yaml index dfe9cfc9b0..e5f2d0bef3 100644 --- a/.github/workflows/kserve_m2m_test.yaml +++ b/.github/workflows/kserve_m2m_test.yaml @@ -3,9 +3,6 @@ on: pull_request: paths: - .github/workflows/kserve_m2m_test.yaml - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - contrib/kserve/** - common/oidc-client/oauth2-proxy/** - common/istio*/** diff --git a/.github/workflows/kserve_test.yaml b/.github/workflows/kserve_test.yaml index 36f86abae1..1264c845f7 100644 --- a/.github/workflows/kserve_test.yaml +++ b/.github/workflows/kserve_test.yaml @@ -3,9 +3,6 @@ on: pull_request: paths: - .github/workflows/kserve_test.yaml - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - contrib/kserve/** - tests/gh-actions/install_cert_manager.sh - common/cert-manager/** diff --git a/.github/workflows/metacontroller_test.yaml b/.github/workflows/metacontroller_test.yaml index 23abd8d4e8..0d1153636a 100644 --- a/.github/workflows/metacontroller_test.yaml +++ b/.github/workflows/metacontroller_test.yaml @@ -3,9 +3,6 @@ on: pull_request: paths: - .github/workflows/metacontroller_test.yaml - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - contrib/metacontroller/** - tests/gh-actions/install_cert_manager.sh - common/cert-manager/** diff --git a/.github/workflows/model_registry_test.yaml b/.github/workflows/model_registry_test.yaml index 4ac7415672..af72d5fe67 100644 --- a/.github/workflows/model_registry_test.yaml +++ b/.github/workflows/model_registry_test.yaml @@ -5,8 +5,6 @@ on: pull_request: paths: - apps/model-registry/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kustomize.sh - tests/gh-actions/install_istio.sh - common/istio*/** diff --git a/.github/workflows/notebook_controller_m2m_test.yaml b/.github/workflows/notebook_controller_m2m_test.yaml index c8d07bc74f..06de50bb33 100644 --- a/.github/workflows/notebook_controller_m2m_test.yaml +++ b/.github/workflows/notebook_controller_m2m_test.yaml @@ -3,9 +3,6 @@ on: pull_request: paths: - .github/workflows/notebook_controller_m2m_test.yaml - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - apps/jupyter/** - common/oidc-client/oauth2-proxy/** - common/istio*/** diff --git a/.github/workflows/notebook_controller_test.yaml b/.github/workflows/notebook_controller_test.yaml index 5866e40184..6573f8f793 100644 --- a/.github/workflows/notebook_controller_test.yaml +++ b/.github/workflows/notebook_controller_test.yaml @@ -4,9 +4,6 @@ on: paths: - .github/workflows/notebook_controller_test.yaml - apps/jupyter/notebook-controller/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - tests/gh-actions/install_istio.sh - common/istio*/** diff --git a/.github/workflows/pipeline_run_from_notebook.yaml b/.github/workflows/pipeline_run_from_notebook.yaml index 614c328501..c368bedcc2 100644 --- a/.github/workflows/pipeline_run_from_notebook.yaml +++ b/.github/workflows/pipeline_run_from_notebook.yaml @@ -5,9 +5,6 @@ on: - .github/workflows/pipeline_run_from_notebook.yaml - apps/jupyter/notebook-controller/upstream/** - apps/pipeline/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - tests/gh-actions/install_istio.sh - tests/gh-actions/install_cert_manager.sh - common/cert-manager/** diff --git a/.github/workflows/pipeline_test.yaml b/.github/workflows/pipeline_test.yaml index 46199964c4..0eeaf7b152 100644 --- a/.github/workflows/pipeline_test.yaml +++ b/.github/workflows/pipeline_test.yaml @@ -4,9 +4,6 @@ on: paths: - .github/workflows/pipeline_test.yaml - apps/pipeline/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - tests/gh-actions/install_istio.sh - tests/gh-actions/install_cert_manager.sh - common/cert-manager/** diff --git a/.github/workflows/profiles_test.yaml b/.github/workflows/profiles_test.yaml index bbf466ca05..caaedac952 100644 --- a/.github/workflows/profiles_test.yaml +++ b/.github/workflows/profiles_test.yaml @@ -4,9 +4,6 @@ on: paths: - .github/workflows/profiles_test.yaml - apps/profiles/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - tests/gh-actions/install_istio.sh - common/istio*/** diff --git a/.github/workflows/ray_test.yaml b/.github/workflows/ray_test.yaml index adc08594c0..f00746d41f 100644 --- a/.github/workflows/ray_test.yaml +++ b/.github/workflows/ray_test.yaml @@ -4,8 +4,6 @@ on: paths: - .github/workflows/ray_test.yaml - contrib/ray/** - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh jobs: build: diff --git a/.github/workflows/seldon_test.yaml b/.github/workflows/seldon_test.yaml index 3a2f78e6a9..4688256e81 100644 --- a/.github/workflows/seldon_test.yaml +++ b/.github/workflows/seldon_test.yaml @@ -3,10 +3,7 @@ on: pull_request: paths: - .github/workflows/seldon_test.yaml - - tests/gh-actions/kind-cluster.yaml - contrib/seldon/** - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - tests/gh-actions/install_istio.sh - common/istio*/** - tests/gh-actions/install_cert_manager.sh diff --git a/.github/workflows/tensorboard_controller_test.yaml b/.github/workflows/tensorboard_controller_test.yaml index d73fb302f4..94e5e0a532 100644 --- a/.github/workflows/tensorboard_controller_test.yaml +++ b/.github/workflows/tensorboard_controller_test.yaml @@ -4,9 +4,6 @@ on: paths: - .github/workflows/tensorboard_controller_test.yaml - apps/tensorboard/tensorboard-controller/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - tests/gh-actions/install_istio.sh - common/istio*/** diff --git a/.github/workflows/tensorboards_web_application_test.yaml b/.github/workflows/tensorboards_web_application_test.yaml index c18c198557..5c24d81294 100644 --- a/.github/workflows/tensorboards_web_application_test.yaml +++ b/.github/workflows/tensorboards_web_application_test.yaml @@ -4,9 +4,6 @@ on: paths: - .github/workflows/tensorboards_web_application_test.yaml - apps/tensorboard/tensorboards-web-app/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - tests/gh-actions/install_istio.sh - common/istio*/** diff --git a/.github/workflows/train_operator_test.yaml b/.github/workflows/train_operator_test.yaml index bd95fe826a..20104d8dbe 100644 --- a/.github/workflows/train_operator_test.yaml +++ b/.github/workflows/train_operator_test.yaml @@ -4,9 +4,6 @@ on: paths: - .github/workflows/train_operator_test.yaml - apps/training-operator/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - tests/gh-actions/install_istio.sh - common/istio*/** - tests/gh-actions/kf-objects/tfjob.yaml diff --git a/.github/workflows/volumes_web_application_test.yaml b/.github/workflows/volumes_web_application_test.yaml index 8e2a53e560..c2a8d0f4f8 100644 --- a/.github/workflows/volumes_web_application_test.yaml +++ b/.github/workflows/volumes_web_application_test.yaml @@ -4,9 +4,6 @@ on: paths: - .github/workflows/volumes_web_application_test.yaml - apps/volumes-web-app/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - tests/gh-actions/install_istio.sh - common/istio*/**