Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use inline for runPolicy and register defaulter function #1330

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Don't use inline for runPolicy and register defaulter function #1330

merged 1 commit into from
Aug 5, 2021

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Aug 3, 2021 •
edited
Loading

Address #1331

  1. PyTorch didn't use runPolicy in the past.
  2. Remove inline in runPolicy.
  3. Register defaulter in scheme.

@Jeffwan Jeffwan changed the title Further unify the job apis Update runPolicy in job types Aug 3, 2021
@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 3, 2021

/cc @gaocegege

@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 4, 2021

/test kubeflow-tf-operator-presubmit

terrytangyuan
terrytangyuan approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jeffwan Jeffwan mentioned this pull request Aug 4, 2021
Closed
@Jeffwan Jeffwan changed the title Update runPolicy in job types Don't use inline for runPolicy and register defaulter function Aug 5, 2021
@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 5, 2021 •
edited
Loading

@terrytangyuan @gaocegege Need a /lgtm form you guys. Tests finally pass now.

@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 5, 2021

/approve
/lgtm

@google-oss-robot
Copy link

@Jeffwan: you cannot LGTM your own PR.

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 5, 2021 •
edited
Loading

Since Terry and Ce already approve the change and test passes. I will merge it.

@Jeffwan Jeffwan merged commit bac8320 into kubeflow:all-in-one-operator Aug 5, 2021
@Jeffwan Jeffwan deleted the clean_up_apis branch August 5, 2021 17:54
Jeffwan added a commit that referenced this pull request Aug 5, 2021
@Jeffwan
Remove inline runPolicy and register defaulter (#1330)
2b255d2
@Jeffwan Jeffwan mentioned this pull request Aug 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@jinchihe jinchihe Awaiting requested review from jinchihe

Assignees
No one assigned
Labels
approved size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jeffwan @google-oss-robot @terrytangyuan @gaocegege