Implement webhook validations for the XGBoostJob

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
kubeflow · Apr 5, 2024 · 58713da · 58713da
1 parent a618d1c
commit 58713da
Show file tree

Hide file tree

Showing 8 changed files with 425 additions and 317 deletions.
diff --git a/manifests/base/webhook/manifests.yaml b/manifests/base/webhook/manifests.yaml
@@ -24,3 +24,23 @@ webhooks:
     resources:
     - pytorchjobs
   sideEffects: None
+- admissionReviewVersions:
+  - v1
+  clientConfig:
+    service:
+      name: webhook-service
+      namespace: system
+      path: /validate-kubeflow-org-v1-xgboostjob
+  failurePolicy: Fail
+  name: vxgboostjob.kb.io
+  rules:
+  - apiGroups:
+    - kubeflow.org
+    apiVersions:
+    - v1
+    operations:
+    - CREATE
+    - UPDATE
+    resources:
+    - xgboostjobs
+  sideEffects: None
diff --git a/pkg/apis/kubeflow.org/v1/xgboost_validation.go b/pkg/apis/kubeflow.org/v1/xgboost_validation.go
diff --git a/pkg/apis/kubeflow.org/v1/xgboost_validation_test.go b/pkg/apis/kubeflow.org/v1/xgboost_validation_test.go