Implement webhook validations for the XGBoostJob

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
kubeflow · Apr 10, 2024 · 850ff3a · 850ff3a
1 parent 1bf512e
commit 850ff3a
Show file tree

Hide file tree

Showing 10 changed files with 429 additions and 318 deletions.
diff --git a/manifests/base/webhook/manifests.yaml b/manifests/base/webhook/manifests.yaml
@@ -24,3 +24,23 @@ webhooks:
     resources:
     - pytorchjobs
   sideEffects: None
+- admissionReviewVersions:
+  - v1
+  clientConfig:
+    service:
+      name: webhook-service
+      namespace: system
+      path: /validate-kubeflow-org-v1-xgboostjob
+  failurePolicy: Fail
+  name: validator.xgboostjob.training-operator.kubeflow.org
+  rules:
+  - apiGroups:
+    - kubeflow.org
+    apiVersions:
+    - v1
+    operations:
+    - CREATE
+    - UPDATE
+    resources:
+    - xgboostjobs
+  sideEffects: None
diff --git a/manifests/base/webhook/patch.yaml b/manifests/base/webhook/patch.yaml
@@ -1,6 +1,9 @@
 - op: replace
   path: /webhooks/0/clientConfig/service/name
   value: training-operator
+- op: replace
+  path: /webhooks/1/clientConfig/service/name
+  value: training-operator
 - op: replace
   path: /metadata/name
   value: validator.training-operator.kubeflow.org
diff --git a/pkg/apis/kubeflow.org/v1/xgboost_validation.go b/pkg/apis/kubeflow.org/v1/xgboost_validation.go
diff --git a/pkg/apis/kubeflow.org/v1/xgboost_validation_test.go b/pkg/apis/kubeflow.org/v1/xgboost_validation_test.go
diff --git a/pkg/cert/cert.go b/pkg/cert/cert.go
@@ -18,9 +18,10 @@ package cert
 
 import (
 	"fmt"
+	"os"
+
 	cert "github.com/open-policy-agent/cert-controller/pkg/rotator"
 	"k8s.io/apimachinery/pkg/types"
-	"os"
 	ctrl "sigs.k8s.io/controller-runtime"
 )