New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we update MPIJob unit test CleanPodPolicy field? #1555

Closed

cheimu opened this issue Mar 20, 2022 · 0 comments · Fixed by #1556

Member

cheimu commented Mar 20, 2022

Current MPIJob's unit test uses cleanPodPolicy field to test the gc logic. However, this is duplicate and in training-operator framework, runPolicy.cleanPodPolicy is used. So should we update it?
https://github.com/kubeflow/training-operator/blob/master/pkg/controller.v1/mpi/mpijob_controller_test.go#L50

cheimu mentioned this issue

Update MPIJob unit tests to use spec.runPolicy.cleanPodPolicy #1556

Merged

1 task

google-oss-prow bot closed this as completed in #1556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment