Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CHANGELOG.md #1432

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Oct 3, 2021

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 3, 2021

/cc @terrytangyuan @kubeflow/wg-training-leads

@google-oss-robot google-oss-robot requested a review from a team October 3, 2021 21:15
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm


**Closed issues:**

- volcano scheduler with customized queue [\#1377](https://github.com/kubeflow/tf-operator/issues/1377)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the redundant \ from?

Copy link
Member Author

@Jeffwan Jeffwan Oct 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably from different release scripts. I will check without @gaocegege on this. This is the latest one I use. @terrytangyuan

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit abfecef into kubeflow:master Oct 4, 2021
@Jeffwan Jeffwan deleted the update_changelog branch October 4, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants