Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MPIJob cannot use gang-scheduling when --enable-gang-scheduling is set #1557

Merged

Conversation

cheimu
Copy link
Member

@cheimu cheimu commented Mar 21, 2022

What this PR does / why we need it:
Thanks for @zw0610 pointing out, the mpijob-operator logic where if gang-scheduler is set is totally opposite. Currently, if gang-scheduler name is not set, then throws an error and directly use default-scheduler instead. However, the correct logic should be if util.IsGangSchedulerSet is true, then throw error and use user's indicated scheduler; else the mpijob-operator should render a default volcano for schedulerName field. So this pr remove ! when check if gang scheduler is set or not

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1548

Checklist:

  • Docs included if any changes are user facing

@aws-kf-ci-bot
Copy link
Contributor

Hi @cheimu. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2014670313

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 36.921%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/mpi/mpijob_controller.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 75.35%
Totals Coverage Status
Change from base Build 2014597889: 0.02%
Covered Lines: 2278
Relevant Lines: 6170

💛 - Coveralls

@zw0610
Copy link
Member

zw0610 commented Mar 21, 2022

/ok-to-test

@zw0610
Copy link
Member

zw0610 commented Mar 26, 2022

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 26, 2022
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheimu, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 28b5e47 into kubeflow:master Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--enable-gang-scheduling=true doesn't work for MPIJob
5 participants