-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: MPIJob cannot use gang-scheduling when --enable-gang-scheduling is set #1557
fix: MPIJob cannot use gang-scheduling when --enable-gang-scheduling is set #1557
Conversation
Hi @cheimu. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 2014670313
💛 - Coveralls |
/ok-to-test |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheimu, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Thanks for @zw0610 pointing out, the mpijob-operator logic where if gang-scheduler is set is totally opposite. Currently, if gang-scheduler name is not set, then throws an error and directly use default-scheduler instead. However, the correct logic should be if
util.IsGangSchedulerSet
is true, then throw error and use user's indicated scheduler; else the mpijob-operator should render a defaultvolcano
for schedulerName field. So this pr remove ! when check if gang scheduler is set or notWhich issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #1548
Checklist: