Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override eks kubernetes version to 1.19 in CI #1582

Closed
wants to merge 1 commit into from

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented May 3, 2022

What this PR does / why we need it:

Fix CI and unblock pending PRs.

/cc @zw0610

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1581

Checklist:

  • Docs included if any changes are user facing

@google-oss-prow google-oss-prow bot requested a review from zw0610 May 3, 2022 09:35
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2263052700

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 37.274%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 77.62%
pkg/controller.v1/pytorch/pytorchjob_controller.go 9 62.25%
Totals Coverage Status
Change from base Build 2251835258: -0.1%
Covered Lines: 2308
Relevant Lines: 6192

💛 - Coveralls

env_vars=[
{
name: "EKS_CLUSTER_VERSION",
value: "1.19",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jeffwan Can't we update it to a later version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. EKS supports up to 1.22 at this moment. However, seems we are still using 1.19 libraries and it may brings compatibility issue?

training-operator/go.mod

Lines 14 to 17 in ce82602

k8s.io/api v0.19.9
k8s.io/apimachinery v0.19.9
k8s.io/client-go v0.19.9
k8s.io/code-generator v0.19.9

I would suggest to bump the version once we upgrade libraries.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aws-kf-ci-bot
Copy link
Contributor

@Jeffwan: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-training-operator-presubmit 481ab18 link /test kubeflow-training-operator-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Jeffwan
Copy link
Member Author

Jeffwan commented May 3, 2022

image

em. Seems all jobs failed and I suspect it could be the problem of ksonnet. If ksonnet can not support 1.19, then it brings additional work..

@johnugeorge
Copy link
Member

@Jeffwan Can you please take a look to temporarily fix CI?

@johnugeorge
Copy link
Member

johnugeorge commented Jun 14, 2022

We can close this PR as we have moved to GHA in #1603

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI stop working due to unsupported kubernetes version being used
5 participants