-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override eks kubernetes version to 1.19 in CI #1582
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 2263052700
💛 - Coveralls |
env_vars=[ | ||
{ | ||
name: "EKS_CLUSTER_VERSION", | ||
value: "1.19", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jeffwan Can't we update it to a later version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. EKS supports up to 1.22 at this moment. However, seems we are still using 1.19 libraries and it may brings compatibility issue?
Lines 14 to 17 in ce82602
k8s.io/api v0.19.9 | |
k8s.io/apimachinery v0.19.9 | |
k8s.io/client-go v0.19.9 | |
k8s.io/code-generator v0.19.9 |
I would suggest to bump the version once we upgrade libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnugeorge @Jeffwan
If we want to use K8s v1.22, we should upgrade eksctl
version in AWS CI worker image.
Ref:
@Jeffwan: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@Jeffwan Can you please take a look to temporarily fix CI? |
We can close this PR as we have moved to GHA in #1603 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
What this PR does / why we need it:
Fix CI and unblock pending PRs.
/cc @zw0610
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #1581
Checklist: