-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look for fully-qualified job role label in Python sdk #1588
Look for fully-qualified job role label in Python sdk #1588
Conversation
Hi @person142. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 2431145721
💛 - Coveralls |
/ok-to-test |
/retest |
@person142: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
IIUC, the test failure: is the issue being handled in #1582, so nothing to do for now but sit tight? |
Can you rebase? |
Currently certain operations like tailing logs from the Python sdk against the latest version of the operator due to a label mistmatch; fix that. Closes kubeflow#1587.
c1c155e
to
c1be1ee
Compare
Rebased! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, person142 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: Currently certain operations like tailing logs from the Python sdk fail against the latest version of the training operator due to a label mismatch; fix that. With this patch I can now tail the logs of a TFJob with the training operator deployed from 1.4 and from master.
Which issue(s) this PR fixes:
Fixes #1587.
Checklist: