Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for fully-qualified job role label in Python sdk #1588

Merged

Conversation

person142
Copy link
Contributor

What this PR does / why we need it: Currently certain operations like tailing logs from the Python sdk fail against the latest version of the training operator due to a label mismatch; fix that. With this patch I can now tail the logs of a TFJob with the training operator deployed from 1.4 and from master.

Which issue(s) this PR fixes:
Fixes #1587.

Checklist:

  • Docs included if any changes are user facing

@aws-kf-ci-bot
Copy link
Contributor

Hi @person142. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

coveralls commented May 6, 2022

Pull Request Test Coverage Report for Build 2431145721

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 37.355%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/pytorch/pytorchjob_controller.go 9 62.25%
Totals Coverage Status
Change from base Build 2428014746: -0.06%
Covered Lines: 2313
Relevant Lines: 6192

💛 - Coveralls

@gaocegege
Copy link
Member

/ok-to-test

@gaocegege
Copy link
Member

/retest

@aws-kf-ci-bot
Copy link
Contributor

@person142: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-training-operator-presubmit c1c155e link /test kubeflow-training-operator-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johnugeorge
Copy link
Member

Can you rebase?

Currently certain operations like tailing logs from the Python sdk
against the latest version of the operator due to a label mistmatch;
fix that.

Closes kubeflow#1587.
@person142
Copy link
Contributor Author

Rebased!

@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, person142

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit b971d8c into kubeflow:master Jun 3, 2022
@person142 person142 deleted the py-sdk-fix-job-role-label branch June 3, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labels in Python client are out of date
5 participants