Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s dependencies to v0.24.1 #1604

Merged
merged 19 commits into from
Jun 6, 2022
Merged

Update k8s dependencies to v0.24.1 #1604

merged 19 commits into from
Jun 6, 2022

Conversation

johnugeorge
Copy link
Member

This follows from PR kubeflow/common#194

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@google-oss-prow google-oss-prow bot removed the lgtm label Jun 4, 2022
@coveralls
Copy link

coveralls commented Jun 4, 2022

Pull Request Test Coverage Report for Build 2443906504

  • 0 of 80 (0.0%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 36.85%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/tensorflow/v1/openapi_generated.go 0 17 0.0%
pkg/apis/xgboost/v1/openapi_generated.go 0 20 0.0%
pkg/apis/mxnet/v1/openapi_generated.go 0 21 0.0%
pkg/apis/pytorch/v1/openapi_generated.go 0 22 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 77.62%
Totals Coverage Status
Change from base Build 2432402956: -0.6%
Covered Lines: 2302
Relevant Lines: 6247

💛 - Coveralls

@gaocegege
Copy link
Member

Some golang tests fail.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnugeorge Thanks for your grateful contribution!

It seems that we failed to launch Kubernetes components.

STEP: bootstrapping test environment
1.6544172439987686e+09 DEBUG controller-runtime.test-env starting control plane
1.6544172440008366e+09 ERROR controller-runtime.test-env unable to start the controlplane {"tries": 0, "error": "fork/exec /usr/local/kubebuilder/bin/etcd: no such file or directory"}

https://github.com/kubeflow/training-operator/runs/6743715231?check_suite_focus=true#step:4:203

@johnugeorge Should we change these scripts like Katib?

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@johnugeorge
Copy link
Member Author

Thanks @tenzen-y . I was planning to do the same

/hold

@johnugeorge
Copy link
Member Author

Please take a look

/hold cancel

@johnugeorge
Copy link
Member Author

Fixes: #1599

.github/workflows/test-go.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
pkg/common/update.go Outdated Show resolved Hide resolved
scripts/gha/goenvtest.sh Outdated Show resolved Hide resolved
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks, @johnugeorge !
I wait for a review from @kubeflow/wg-training-leads .

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnugeorge,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for your contribution! 🎉 👍

@google-oss-prow google-oss-prow bot added the lgtm label Jun 6, 2022
@google-oss-prow google-oss-prow bot merged commit 7761578 into kubeflow:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants