Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle all restart policies #1649

Merged
merged 4 commits into from
Dec 30, 2022

Conversation

abin-thomas-by
Copy link
Contributor

What this PR does / why we need it:
Handle all restart policies mentioned in the docs. Pod level restarts won't work when failure happens for a system reason.
Similar to PR :- kubeflow/common#189

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@abin-thomas-by
Copy link
Contributor Author

/assign @Jeffwan

@johnugeorge
Copy link
Member

johnugeorge commented Dec 29, 2022

@abin-thomas-by Can you rebase?

@abin-thomas-by
Copy link
Contributor Author

@johnugeorge done!

@johnugeorge
Copy link
Member

/lgtm

/assign @terrytangyuan

@coveralls
Copy link

coveralls commented Dec 30, 2022

Pull Request Test Coverage Report for Build 3806422891

  • 12 of 16 (75.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 39.231%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/tensorflow/tfjob_controller.go 12 16 75.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/tensorflow/tfjob_controller.go 1 70.83%
pkg/controller.v1/mpi/mpijob_controller.go 2 76.99%
Totals Coverage Status
Change from base Build 3782940340: -0.1%
Covered Lines: 2663
Relevant Lines: 6788

💛 - Coveralls

@johnugeorge
Copy link
Member

Please fix formatting issues

@google-oss-prow google-oss-prow bot removed the lgtm label Dec 30, 2022
@abin-thomas-by
Copy link
Contributor Author

@johnugeorge fixed

@johnugeorge
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 30, 2022
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abin-thomas-by, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 84961f2 into kubeflow:master Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants