-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle all restart policies #1649
Conversation
/assign @Jeffwan |
@abin-thomas-by Can you rebase? |
@johnugeorge done! |
/lgtm /assign @terrytangyuan |
Pull Request Test Coverage Report for Build 3806422891
💛 - Coveralls |
Please fix formatting issues |
@johnugeorge fixed |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abin-thomas-by, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Handle all restart policies mentioned in the docs. Pod level restarts won't work when failure happens for a system reason.
Similar to PR :- kubeflow/common#189
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: