Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the cmd to support MPI operator in ReadME #1656

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

denkensk
Copy link
Member

@denkensk denkensk commented Sep 1, 2022

Signed-off-by: Alex Wang wangqingcan1990@gmail.com

What this PR does / why we need it:
Update the cmd to support MPI operator

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Alex Wang <wangqingcan1990@gmail.com>
@coveralls
Copy link

coveralls commented Sep 1, 2022

Pull Request Test Coverage Report for Build 2971227910

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 39.819%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 6 77.08%
Totals Coverage Status
Change from base Build 2889654997: 0.0%
Covered Lines: 2331
Relevant Lines: 5854

💛 - Coveralls

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: denkensk, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit afb652f into kubeflow:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants