Upgrade the kubernetes dependencies to v1.27 #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenzen-y
force-pushed
the
upgrade-k8s-1.27
branch
2 times, most recently
from
9fc5308
to
e595fa1
Compare
tenzen-y
force-pushed
the
upgrade-k8s-1.27
branch
from
e595fa1
to
ade332d
Compare
1 task
tenzen-y
force-pushed
the
upgrade-k8s-1.27
branch
from
ade332d
to
cf8fe26
Compare
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
force-pushed
the
upgrade-k8s-1.27
branch
from
cf8fe26
to
d830c63
Compare
tenzen-y
commented
Jun 18, 2023
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // using onOwnerCreateFunc is easier to set defaults | ||
| if err = c.Watch(&source.Kind{Type: &kubeflowv1.MPIJob{}}, &handler.EnqueueRequestForObject{}, | ||
| if err = c.Watch(source.Kind(mgr.GetCache(), &kubeflowv1.MPIJob{}), &handler.EnqueueRequestForObject{}, |
There was a problem hiding this comment.
The source.Kind{} typed. was replaced with source.Kind() function:
tenzen-y
commented
Jun 18, 2023
| OwnerType: &kubeflowv1.MPIJob{}, | ||
| }, predicate.Funcs{ | ||
| // eventHandler for owned objects | ||
| eventHandler := handler.EnqueueRequestForOwner(mgr.GetScheme(), mgr.GetRESTMapper(), &kubeflowv1.MPIJob{}, handler.OnlyControllerOwner()) |
There was a problem hiding this comment.
The handler.EnqueueRequestForOwner{} typed was replaced with handler.EnqueueRequestForOwner() function:
|
/assign @johnugeorge |
|
friendly ping @johnugeorge :) |
|
Sorry for late review. Thanks @tenzen-y for adding 1.27 support /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I upgraded kubernetes dependencies to v1.27.
Note: the latest controller-runtime has huge breaking changes without backward compatibility. So I modified the
SetupWithManagerin all controllers.ref: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #1803
Checklist: