Refactoring tests in common/controller.v1

[tenzen-y]

What this PR does / why we need it:
I refactored tests in common/controller.v1. And then, I removed TestJobController.
Also, I moved the following tests into "Test for controller.v1/common" in TFJob ones since those tests deeply depend on Reconciler, such as TFJobReconciler:

• TestCleanupJobIfTTL
• TestCleanupJob
• TestJobController_CreateNewService

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Part-of: #1816

Checklist:

• Docs included if any changes are user facing

[coveralls]

Pull Request Test Coverage Report for Build 5446399997

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 85 unchanged lines in 5 files lost coverage.
• Overall coverage decreased (-0.8%) to 33.552%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/controller.v1/mpi/mpijob_controller.go	2	79.03%
pkg/controller.v1/pytorch/pytorchjob_controller.go	9	59.79%
pkg/controller.v1/common/job.go	13	6.92%
pkg/controller.v1/common/job_controller.go	19	0%
pkg/controller.v1/common/service.go	42	1.86%

Totals
Change from base Build 5371475460:	-0.8%
Covered Lines:	3270
Relevant Lines:	9746

---

💛 - Coveralls

[terrytangyuan]

Thanks!

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tenzen-y]

@terrytangyuan Thanks for the review. Can you restart CI Go Test / Test (1.27.1) (pull_request)? It's a flaky test: #1820

[terrytangyuan]

done

[tenzen-y]

I will work on improving flaky tests...