Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement webhook validation for the XGBoostJob #2037

Closed
wants to merge 2 commits into from

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
I implemented webhook validations for the XGBoostJob.
Additionally, I didn't add any additional validations. The traininig-operator has the same validations the same as before.

Although we potentially commonize podTemplate validations, I leave such commonize in the follow-ups.

This PR depends on #2035

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Part-of #1993

Checklist:

  • Docs included if any changes are user facing

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member Author

/hold

@coveralls
Copy link

coveralls commented Mar 27, 2024

Pull Request Test Coverage Report for Build 8635149231

Details

  • 105 of 248 (42.34%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 35.173%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/webhooks/webhooks.go 0 3 0.0%
pkg/webhooks/xgboost/xgboostjob_webhook.go 49 74 66.22%
pkg/webhooks/pytorch/pytorchjob_webhook.go 56 83 67.47%
pkg/cert/cert.go 0 31 0.0%
cmd/training-operator.v1/main.go 0 57 0.0%
Files with Coverage Reduction New Missed Lines %
cmd/training-operator.v1/main.go 1 0.0%
Totals Coverage Status
Change from base Build 8585006097: -0.2%
Covered Lines: 4341
Relevant Lines: 12342

💛 - Coveralls

@tenzen-y tenzen-y force-pushed the implement-xgboost-webhook-validation branch from 2190394 to 58713da Compare April 5, 2024 12:49
@tenzen-y
Copy link
Member Author

tenzen-y commented Apr 5, 2024

Rebased.

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y force-pushed the implement-xgboost-webhook-validation branch from 58713da to 70b587d Compare April 10, 2024 17:10
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y force-pushed the implement-xgboost-webhook-validation branch from 70b587d to 512723f Compare April 10, 2024 17:13
@tenzen-y
Copy link
Member Author

This is replaced with #2052.
/close

@google-oss-prow google-oss-prow bot closed this Apr 10, 2024
Copy link

@tenzen-y: Closed this PR.

In response to this:

This is replaced with #2052.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants