Implement webhook validations for the XGBoostJob #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Apr 10, 2024
|
/hold |
Pull Request Test Coverage Report for Build 8637552831Details
💛 - Coveralls |
tenzen-y
force-pushed
the
implement-xgboost-webhook-validation
branch
2 times, most recently
from
850ff3a
to
d981e7e
Compare
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
force-pushed
the
implement-xgboost-webhook-validation
branch
from
d981e7e
to
ffe30ca
Compare
|
These are the third webhook validations. PTAL. |
|
/hold cancel |
johnugeorge
pushed a commit
to johnugeorge/training-operator
that referenced
this pull request
Apr 28, 2024
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
johnugeorge
pushed a commit
to johnugeorge/training-operator
that referenced
this pull request
Apr 28, 2024
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I implemented webhook validations for the XGBoostJob.
Additionally, I didn't add any additional validations. The traininig-operator has the same validations the same as before.
Although we potentially commonize podTemplate validations, I leave such commonize in the follow-ups.
This PR depends on #2035
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Part-of #1993
Checklist: