Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use a mode=min in the builder cache #2053

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Apr 10, 2024

What this PR does / why we need it:
I replaced cache-to mode with min (default value) to avoid the following timeout errors:

#7 writing layer sha256:202111e1e67fd289b555ea0a5f198b9919220afe610c9e070268fdd75c3dd5e2 600.1s done
#7 ERROR: error writing layer blob: maximum timeout reached
------
 > exporting to GitHub Actions Cache:
------
WARNING: No output specified with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load
ERROR: failed to solve: error writing layer blob: maximum timeout reached
Error: buildx failed with: ERROR: failed to solve: error writing layer blob: maximum timeout reached

https://github.com/kubeflow/training-operator/actions/runs/8635377472/job/23674563980?pr=2051#step:5:1294

xref: docker/buildx#841

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y
Copy link
Member Author

cc: @johnugeorge

@johnugeorge
Copy link
Member

/lgtm

Thanks @tenzen-y

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8636359575

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 35.227%

Totals Coverage Status
Change from base Build 8635271448: 0.06%
Covered Lines: 4341
Relevant Lines: 12323

💛 - Coveralls

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [tenzen-y,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1bf512e into kubeflow:master Apr 10, 2024
39 checks passed
@tenzen-y tenzen-y deleted the stop-cache-max branch April 10, 2024 19:25
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants