-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make basic community membership guidelines clearer #3827
Make basic community membership guidelines clearer #3827
Conversation
Hi @anishasthana. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test
2931fd6
to
4b3de1b
Compare
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
b17b1ac
to
b0d245b
Compare
908075a
to
90c127a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a great improvements over the current process. Thanks!
One thing that is being discussed is how to encourage non-code contributions. This may not be something this PR covers and can be future improvements IMO. I'll share with the outreach team to help review.
@anishasthana Did you address all of the comments from this PR: kubeflow/community#737? /assign @kubeflow/wg-training-leads @kubeflow/wg-automl-leads @kubeflow/wg-notebooks-leads @kubeflow/wg-pipeline-leads @kubeflow/wg-data-leads |
@andreyvelich this PR is ready for second review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anishasthana I believe a clearer guideline helps a lot !
Wdyt about the suggestions below, based on previously received feedback.
Thank you for your consideration in any case.
a843fef
to
63c319b
Compare
63c319b
to
1511875
Compare
1511875
to
84b0336
Compare
…root directory Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
dc2d259
to
96cb2ee
Compare
96cb2ee
to
31cc339
Compare
|
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
31cc339
to
e85e50d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this effort @anishasthana!
/lgtm
/assign @terrytangyuan @kubeflow/kubeflow-steering-committee @hbelmiro @StefanoFioravanzo
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thank you @anishasthana for this work, makes a great improvement on governance aspects |
This PR adds guidelines around the kubeflow community membership.
This set of guidelines is heavily inspired by the Kubernetes guidelines at https://github.com/kubernetes/community/blob/master/community-membership.md?plain=1#community-membership
cc @kubeflow/kubeflow-steering-committee