Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a port-forwarding example. #232

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Add a port-forwarding example. #232

merged 2 commits into from
Jan 29, 2019

Conversation

brendandburns
Copy link
Contributor

Part of #229

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 27, 2019
@brendandburns brendandburns mentioned this pull request Jan 27, 2019
Closed
tg123
tg123 approved these changes Jan 27, 2019
View reviewed changes
examples/portforward/PortForward.cs Outdated

Socket handler = null;

var t = new Thread(new ThreadStart(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task.Run(() => ....); // typical c# now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@brendandburns
Copy link
Contributor Author

Thanks for the review. Comment addressed, please re-check!

@tg123
Copy link
Member

tg123 commented Jan 28, 2019

LGTM

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2019
@brendandburns
Copy link
Contributor Author

Self LGTM on the LGTM above.

@k8s-ci-robot k8s-ci-robot merged commit 588807f into kubernetes-client:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tg123 tg123 tg123 approved these changes

@krabhishek8260 krabhishek8260 Awaiting requested review from krabhishek8260

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendandburns @k8s-ci-robot @tg123