-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add kubectl equivalent examples #1254
chore: add kubectl equivalent examples #1254
Conversation
Welcome @Ananya2001-an! |
Thanks for this PR! I think it would be even better to introduce a It would be similar to https://github.com/kubernetes-client/java/tree/master/extended/src/main/java/io/kubernetes/client/extended/kubectl |
Yeah that sounds good! I will work on it. I think we can even add some tests for the same with jest, wdyt? But I would work on it in a separate PR to keep things simple for now :) |
Hey @brendandburns I created a |
Yes, you're right, there's no good equivalent of the generic client in Java. We should add that :) If that's too much work, feel free to revert this PR just to the examples and we can merge those and work on the generic |
I have reverted the changes, @brendandburns you can review now :) |
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ananya2001-an, brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to #1253
Created a
kubectl/equivalents
folder inside examples. Each file corresponds to the relevant kubectl command making it easier for users to understand the usage of the client. Makes it more readable and maintainable.Current files added:
... more to be added