-
Notifications
You must be signed in to change notification settings - Fork 1.6k
make the fsid device setting configurable #1214
make the fsid device setting configurable #1214
Conversation
Welcome @thirdeyenick! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I signed it |
Thx for prs. I’m looking into why e2e is not building/running, it worked a few days ago. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@thirdeyenick cool, having the same issue. Would you have an example yaml file, which shows how to use it? |
@thirdeyenick sorry to disturb, but still looking around a fix, as this hasn't been merged into the helm repo (helm/charts#18965). I was wondering how you fixed it. Any help is more than welcome! Super thanks Nick. |
@wongma7 any chance a new release would be made for this? Thanks! It looks that it is not included in v2.2.2 |
This makes the fsid_device setting configurable. To not affect already deployed nfs provisioners I did not change the default to
false
. This should solve issue #1212.