Create proto definitions for cosi #8
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
|
thanks @brahmaroutu. LGTM |
|
/assign wlan0 |
|
/approve |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@xing-yang Can you please review. |
|
@brahmaroutu I have the same questions as @xing-yang |
brahmaroutu
force-pushed
the
proto_definitions
branch
from
27f9415 to
3a7ea28
Compare
k8s-ci-robot
removed
the
lgtm
brahmaroutu
force-pushed
the
proto_definitions
branch
from
3a7ea28 to
846906d
Compare
go.mod
Outdated
| @@ -0,0 +1,9 @@ | |||
| module github.com/container-object-storage-interface/spec | |||
|
|
|||
| go 1.14 | |||
There was a problem hiding this comment.
Can this be updated to 1.15. 1.15 is required for k8s 1.19.
brahmaroutu
force-pushed
the
proto_definitions
branch
from
846906d to
59aecec
Compare
|
@xing-yang @wlan0 I have updated the proto file as per the comments adding detailed documentation of the calls and parameters. Please review. |
brahmaroutu
force-pushed
the
proto_definitions
branch
from
59aecec to
52441ec
Compare
cosi.proto
Outdated
| rpc ProvisionerCreateBucket (ProvisionerCreateBucketRequest) returns (ProvisionerCreateBucketResponse) {} | ||
| // This call is made to delete the bucket in the backend. | ||
| // If the bucket has already been deleted, then no error should be returned. | ||
| // If the bucket has already been deleted, then no error should be returned. |
There was a problem hiding this comment.
Looks like you have not pushed your changes? I still see two duplicate lines:).
cosi.proto
Outdated
| // This call grants access to a particular principal. The principal is the account for which this access should be granted. | ||
| // If the principal is set, then it should be used as the username of the created credentials. | ||
| // If the principal is empty, then a new service account should be created in the backend that satisfies the requested access_policy. | ||
| // The principal returned in the repsonce will be used as the unique identifier for deleting this access by calling ProvisionerRevokeBucketAccess. |
| rpc ProvisionerGrantBucketAccess (ProvisionerGrantBucketAccessRequest) returns (ProvisionerGrantBucketAccessResponse); | ||
| rpc ProvisionerRevokeBucketAccess (ProvisionerRevokeBucketAccessRequest) returns (ProvisionerRevokeBucketAccessResponse); | ||
| } | ||
|
|
There was a problem hiding this comment.
Sounds good. In CSI spec repo, we only need to update spec.md and csi.proto will be generated as well.
xing-yang
left a comment
xing-yang
left a comment
There was a problem hiding this comment.
Looks like you forgot to push your changes?
cosi.proto
Outdated
| rpc ProvisionerCreateBucket (ProvisionerCreateBucketRequest) returns (ProvisionerCreateBucketResponse) {} | ||
| // This call is made to delete the bucket in the backend. | ||
| // If the bucket has already been deleted, then no error should be returned. | ||
| // If the bucket has already been deleted, then no error should be returned. |
There was a problem hiding this comment.
Looks like you have not pushed your changes? I still see two duplicate lines:).
brahmaroutu
force-pushed
the
proto_definitions
branch
from
52441ec to
534dd4c
Compare
|
@xing-yang I am sorry I did not push the code. I now have updated the code. Please review. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brahmaroutu, wlan0, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 participants
Create the initial photo definitions for COSI Provisioner.
/assign @wlan0