-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update influxdb and grafana dependencies #1993
Update influxdb and grafana dependencies #1993
Conversation
Supporting docs for moving to libc on busybox shows its default is |
Single datapoint: this launches and runs (with |
Hello :) What's the status on this PR? Do you need help? BTW, Grafana v5.0.4 and influxdb v1.5.2 are out |
I can update tomorrow, but I'm stuck on how to test the "static" linking in sqlite. It's easy to repro the warnings and resulting image, just switch to 5.0.4 and |
The "dlopen in static linked app" issue did not get many answers in the go-sqlite3 repo ... I don't know golang but the issue might be related to golang/go#21421 (comment) and confluentinc/confluent-kafka-go#59 (comment) ... TL;DR: try adding the flag |
/ok-to-test |
@Nodraak Changing I pushed the changes to use the Per |
So, I've cloned your repo and checkout-ed your branch. I have ran Everything is running fine without errors. I'm not sure what you meant by |
Thanks for another good data point! I say "stuck" in that I don't know EXACTLY where the sqlite code is used, or how I can prove the negative - I'd like to see a +/- where |
@andyxning @loburm any suggestions on how to test this to satisfy Unit and e2e both seem to be working, but it's unclear if they use the built images for the dependencies or if they're pulling whatever base they already have. |
Will take a look at this later today. |
ping @andyxning |
Sorry, later today. @Nodraak |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 007, andyxning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update the builds for
influxdb
andgrafana
to use recent versions.Can't get
grafana
to cross-compile properly with 5.x because of warnings like this againstgo-sqlite3
even when compiling statically:I don't have a good way to test, but if that's not a showstopper (as suggested elsewhere) then It would be nice to get
grafana
bumped to 5.0.3 as well. It might be as easy as changingFROM busybox
toFROM busybox:glibc
.