Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

feat: initial support for amazon-vpc-cni-k8s #1463

Merged
merged 4 commits into from
Oct 1, 2018

Conversation

mumoshu
Copy link
Contributor

@mumoshu mumoshu commented Sep 30, 2018

Add the below configuration to your cluster.yaml and then amazon-vpc-cni-k8s is installed as a daemonset for assigning VPC private IP addresses to your K8S pods.

kubernetes:
  networking:
    amazonVPC:
      enabled: true

Controller nodes have a k8s manifest file for installing amazon-vpc-cni-k8s daemonset. It adds an init container to copy all the cni binaries bundled to the hyperkube image. Otherwise amazon-vpc-cni-k8s doesn't work due to missing the loopback cni bin.

kubelet on worker and controller nodes now have appropriate --node-ip and --max-pods settings to make amazon-vpc-cni-k8s reliably work.

This is one of prerequisites towards the EKS support.

TODOs:

ref #1434

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2018
@codecov-io
Copy link

codecov-io commented Sep 30, 2018

Codecov Report

Merging #1463 into master will decrease coverage by 0.21%.
The diff coverage is 11.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1463      +/-   ##
==========================================
- Coverage    38.1%   37.88%   -0.22%     
==========================================
  Files          74       75       +1     
  Lines        4559     4593      +34     
==========================================
+ Hits         1737     1740       +3     
- Misses       2580     2611      +31     
  Partials      242      242
Impacted Files Coverage Δ
core/controlplane/config/amazon_vpc.go 0% <0%> (ø)
core/controlplane/config/config.go 63.46% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c113c7e...5dad6f8. Read the comment docs.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2018
@mumoshu mumoshu added this to the v0.12.0 milestone Oct 1, 2018
Add the below configuration to your `cluster.yaml` and then `amazon-vpc-cni-k8s` is installed as a daemonset for assigning VPC private IP addresses to your K8S pods.

```yaml
kubernetes:
  networking:
    amazonVPC:
      enabled: true
```

Controller nodes have a k8s manifest file for installing amazon-vpc-cni-k8s daemonset. It adds an init container to copy all the cni binaries bundled to the hyperkube image. Otherwise amazon-vpc-cni-k8s doesn't work due to missing the `loopback` cni bin.

kubelet on worker and controller nodes now have appropriate `--node-ip` and `--max-pods` settings to make amazon-vpc-cni-k8s reliably work.

This is one of prerequisites towards the EKS support.

ref kubernetes-retired#1434
Just because it is the latest release and I've used it for testing in combination with the initial amazon-vpc-cni-k8s support.
The extraneous `}` in a line for installing the dashboard has been preventing
the `install-kube-system` script from succeeding. This fixes that.
@mumoshu
Copy link
Contributor Author

mumoshu commented Oct 1, 2018

See af4d217, 0707ed0 and 5dad6f8, without huge vendor updates, to see the point of this PR.

@mumoshu mumoshu merged commit 6126a93 into kubernetes-retired:master Oct 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants