Fix restricted SG rules for named target port #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/L
kishorj
force-pushed
the
restricted-sg
branch
from
3c84543 to
28a7219
Compare
kishorj
added
the
tide/merge-method-squash
M00nF1sh
reviewed
Oct 29, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
haouc
pushed a commit
to haouc/aws-alb-ingress-controller
that referenced
this pull request
Nov 3, 2021
Timothy-Dougherty
pushed a commit
to adammw/aws-load-balancer-controller
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2317
Description
With SG port restriction feature enabled, ingress model builder did not build the tgb networking configuration with the correct port when backend service port spec contained named ports. As a result, the security group did not have appropriate rules to allow backend traffic from the load balancer.
Testing
Added e2e tests to verify traffic in case of named target ports. The traffic tests failed in case of the old controller, and was successful with the new controller image.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯