support IPv6 Pods during AZ detection #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## main #2375 +/- ##
==========================================
+ Coverage 53.87% 53.95% +0.08%
==========================================
Files 139 140 +1
Lines 7802 7829 +27
==========================================
+ Hits 4203 4224 +21
- Misses 3279 3288 +9
+ Partials 320 317 -3
Continue to review full report at Codecov.
|
kishorj
reviewed
Nov 24, 2021
| type VPCInfo ec2sdk.Vpc | ||
|
|
||
| // AssociatedIPv4CIDRs computes associated IPv4CIDRs for VPC. | ||
| func (vpc *VPCInfo) AssociatedIPv4CIDRs() []string { |
There was a problem hiding this comment.
GetAssociatedIPv4CIDRs instead?
| } | ||
|
|
||
| // AssociatedIPv6CIDRs computes associated IPv6CIDRs for VPC. | ||
| func (vpc *VPCInfo) AssociatedIPv6CIDRs() []string { |
kishorj
added
the
tide/merge-method-squash
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Timothy-Dougherty
pushed a commit
to adammw/aws-load-balancer-controller
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up PR for #1862
Additional notes:
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯