Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect volume usage on Windows node with host process deployment #1337

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jul 31, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: incorrect volume usage on Windows node with host process deployment
BTW, we don't have a plan to fix it on Windows node depending on csi-proxy since it requires fix in csi-proxy and csi-proxy is actually retired.

  • get permission denied in non host process deployment
I0813 14:38:57.305188    7060 utils.go:76] GRPC call: /csi.v1.Node/NodeGetVolumeStats
I0813 14:38:57.305188    7060 utils.go:77] GRPC request: {"volume_id":"csi-c67aa8fb6faecd9e38978fab46a3b86d1de33a34c810ea2c7a1250431092c4ad","volume_path":"c:\\var\\lib\\kubelet\\pods\\3fa8e1e7-f4af-4609-8527-33f4e4395941\\volumes\\kubernetes.io~csi\\test-volume-1\\mount"}
E0813 14:38:57.374862    7060 utils.go:81] GRPC error: rpc error: code = Internal desc = failed to get free space on path c:\var\lib\kubelet\pods\3fa8e1e7-f4af-4609-8527-33f4e4395941\volumes\kubernetes.io~csi\test-volume-1\mount: Access is denied.
  • works in host process deployment
I0813 15:05:12.981989    1188 utils.go:76] GRPC call: /csi.v1.Node/NodeGetVolumeStats
I0813 15:05:12.981989    1188 utils.go:77] GRPC request: {"volume_id":"capz-b1ujhx#f2b755625a29b4c7e9804f4#pvc-6cc51713-bb44-4756-ad6b-35f5e504f963###azurefile-9188","volume_path":"c:\\var\\lib\\kubelet\\pods\\b4840a41-22dd-4adf-9266-05568bc51dea\\volumes\\kubernetes.io~csi\\pvc-6cc51713-bb44-4756-ad6b-35f5e504f963\\mount"}
I0813 15:05:12.998393    1188 utils.go:83] GRPC response: {"usage":[{"available":10737352704,"total":10737418240,"unit":1,"used":65536}]}

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: incorrect volume usage on Windows node

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 31, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 31, 2023
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 13, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2023
@andyzhangx andyzhangx force-pushed the fix-GetVolumeStats-win branch 3 times, most recently from d32baac to 721e299 Compare August 13, 2023 14:03
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx changed the title fix: incorrect volume usage on Windows node [WIP] fix: incorrect volume usage on Windows node Aug 13, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2023
fix

fix

fix gofmt

test: skip test on darwin

fix
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx changed the title [WIP] fix: incorrect volume usage on Windows node fix: incorrect volume usage on Windows node with host process deployment Aug 15, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2023
@andyzhangx
Copy link
Member Author

/retest

1 similar comment
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit 6ad4199 into master Aug 16, 2023
16 checks passed
@andyzhangx
Copy link
Member Author

/cherrypick release-1.28

@k8s-infra-cherrypick-robot

@andyzhangx: #1337 failed to apply on top of branch "release-1.28":

Applying: fix: incorrect volume usage on Windows node
Using index info to reconstruct a base tree...
M	go.mod
Falling back to patching base and 3-way merge...
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: incorrect volume usage on Windows node
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants