Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api-model: remove --service-account-issuer #566

Merged
merged 1 commit into from
Mar 23, 2021
Merged

api-model: remove --service-account-issuer #566

merged 1 commit into from
Mar 23, 2021

Conversation

chewong
Copy link
Member

@chewong chewong commented Mar 19, 2021

Signed-off-by: Ernest Wong chuwon@microsoft.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

With Azure/aks-engine#4262, it should have the correct default value for the --service-account-issuer flag.

/kind failing-testing
/assign @feiskyer

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

api-model: remove --service-account-issuer
48a3edf 
Signed-off-by: Ernest Wong <chuwon@microsoft.com>
@k8s-ci-robot
Copy link
Contributor

@chewong: The label(s) kind/failing-testing cannot be applied, because the repository doesn't have them.

In response to this:

Signed-off-by: Ernest Wong chuwon@microsoft.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

With Azure/aks-engine#4262, it should have the correct default value for the --service-account-issuer flag.

/kind failing-testing
/assign @feiskyer

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 19, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 19, 2021
@chewong
Copy link
Member Author

chewong commented Mar 19, 2021

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 19, 2021
@feiskyer
Copy link
Member

have the aks-engine version released and updated in test-infra jobs?

@chewong
Copy link
Member Author

chewong commented Mar 22, 2021 •
edited
Loading

I will update the aks-engine version to nightly build after this PR is merged

@feiskyer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chewong, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 75e6607 into kubernetes-sigs:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chewong @k8s-ci-robot @feiskyer