Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Removed Link in Roadmap.md and re-phrased the text. #8466

Closed
wants to merge 2 commits into from
Closed

🌱 Removed Link in Roadmap.md and re-phrased the text. #8466

wants to merge 2 commits into from

Conversation

gantanikhilraj
Copy link
Contributor

Removed link to roadmap discussion from the book and,
Replaced the text :
From,
You can find the Cluster API roadmap discussion at GitHub. Please feel free to participate!
to
The Cluster API roadmap discussion will take place during the weekly office hours.

Fixes #8451

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 4, 2023

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @gantanikhilraj!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oscr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @gantanikhilraj. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 4, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 4, 2023
@killianmuldoon
Copy link
Contributor

@gantanikhilraj - let me know if you have any trouble signing the CLA! 🙂

@gantanikhilraj
Copy link
Contributor Author

gantanikhilraj commented Apr 4, 2023

@gantanikhilraj - let me know if you have any trouble signing the CLA! 🙂
@killianmuldoon
Thanks for that, could you guide me how should I sign the CLA?

@killianmuldoon
Copy link
Contributor

/easycla

@killianmuldoon
Copy link
Contributor

I think if you go to this link you should be able to sign it: https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/20677499/124157517/8466/#/?version=2

@killianmuldoon
Copy link
Contributor

Oh - another issue here. Looks like your github account isn't linked to the same address you made the commits with. You should be able to fix that by following this: https://help.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-linked-to-the-wrong-user

@gantanikhilraj
Copy link
Contributor Author

Oh - another issue here. Looks like your github account isn't linked to the same address you made the commits with. You should be able to fix that by following this: https://help.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-linked-to-the-wrong-user

@killianmuldoon I am unbale to sign for CLA, although I am using same email. any suggestions on how to sign CLA ?

@killianmuldoon
Copy link
Contributor

Which parts of https://help.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-linked-to-the-wrong-user are you having trouble with? Your commit is linked to nikhilraj2003 rather than your current Github email / username. You'll be able to see this locally by running git log and looking at the commit author.

You can change this by setting your email on your local git config, amending the commit locally, and then pushing to this branch.

@killianmuldoon
Copy link
Contributor

Can you rebase to squash the commits leaving only the second one?

@gantanikhilraj
Copy link
Contributor Author

gantanikhilraj commented Apr 4, 2023

Can you rebase to squash the commits leaving only the second one?
@killianmuldoon
I will close this PR and open a new PR to sign CLA.

@killianmuldoon
Copy link
Contributor

I will close this PR and open a new PR to sign CLA.

No need - locally you can run git rebase HEAD~2. Then you can follow the instructions to modify your existing state to what you're looking for. You could drop your latest commit and continue. Then you should be able to change the author on the previous commit by running git commit --amend --author="Author Name <email@address.com>". After that you might have to force push onto this branch, but your patch should be in the correct state at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove link to roadmap discussion from the book
3 participants