-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Removed Link in Roadmap.md and re-phrased the text. #8466
Conversation
|
Welcome @gantanikhilraj! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @gantanikhilraj. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@gantanikhilraj - let me know if you have any trouble signing the CLA! 🙂 |
|
/easycla |
I think if you go to this link you should be able to sign it: https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/20677499/124157517/8466/#/?version=2 |
Oh - another issue here. Looks like your github account isn't linked to the same address you made the commits with. You should be able to fix that by following this: https://help.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-linked-to-the-wrong-user |
@killianmuldoon I am unbale to sign for CLA, although I am using same email. any suggestions on how to sign CLA ? |
Which parts of https://help.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-linked-to-the-wrong-user are you having trouble with? Your commit is linked to nikhilraj2003 rather than your current Github email / username. You'll be able to see this locally by running You can change this by setting your email on your local git config, amending the commit locally, and then pushing to this branch. |
Can you rebase to squash the commits leaving only the second one? |
|
No need - locally you can run |
Removed link to roadmap discussion from the book and,
Replaced the text :
From,
You can find the Cluster API roadmap discussion at GitHub. Please feel free to participate!
to
The Cluster API roadmap discussion will take place during the weekly office hours.
Fixes #8451