-
Notifications
You must be signed in to change notification settings - Fork 201
[CI] update crdify CI to allow exempt/ack break change. #1909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zetxqx The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
523c566 to
c98b37b
Compare
|
/assign @kfswain @ahg-g @nirrozenbaum I would like to add a label This will unblock #1820. Can you take a look? tested(zetxqx#8) on my personal project: I believe only maintainers can add the label. |
|
I’ve looked into #1820. I think validation might be bypassed in some edge cases that are very specific. as maintainers (with admin permission), we can merge the original PR manually. I believe merging manually to bypass makes it very unusual and will cause maintainers to think twice before doing so. on the other hand, having automated bypassing process concerns me much more. |
Agree with @nirrozenbaum completely |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: