Skip to content

Conversation

@zetxqx
Copy link
Contributor

@zetxqx zetxqx commented Nov 26, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Allow API breaking change by adding /ack-breaking-changes

@netlify
Copy link

netlify bot commented Nov 26, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit c565c7f
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69279d075b832c000852cae1
😎 Deploy Preview https://deploy-preview-1909--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zetxqx
Once this PR has been reviewed and has the lgtm label, please assign nirrozenbaum for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 26, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 26, 2025
@zetxqx zetxqx force-pushed the ciexempt branch 5 times, most recently from 523c566 to c98b37b Compare November 27, 2025 00:22
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 27, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 27, 2025
@zetxqx
Copy link
Contributor Author

zetxqx commented Nov 27, 2025

/assign @kfswain @ahg-g @nirrozenbaum

I would like to add a label ack-breaking-changes to bypass the Crd verify check.

This will unblock #1820. Can you take a look?

tested(zetxqx#8) on my personal project: I believe only maintainers can add the label.

@nirrozenbaum
Copy link
Contributor

nirrozenbaum commented Nov 27, 2025

I’ve looked into #1820.
I’m a bit concerned about the current PR.
my main concern is that we have validation and now we add automation to bypass validation.

I think validation might be bypassed in some edge cases that are very specific. as maintainers (with admin permission), we can merge the original PR manually.

I believe merging manually to bypass makes it very unusual and will cause maintainers to think twice before doing so. on the other hand, having automated bypassing process concerns me much more.

@nirrozenbaum
Copy link
Contributor

/hold

@zetxqx may we close this one now that #1820 is merged?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2025
@zetxqx zetxqx closed this Nov 27, 2025
@kfswain
Copy link
Collaborator

kfswain commented Nov 27, 2025

I’ve looked into #1820.

I’m a bit concerned about the current PR.

my main concern is that we have validation and now we add automation to bypass validation.

I think validation might be bypassed in some edge cases that are very specific. as maintainers (with admin permission), we can merge the original PR manually.

I believe merging manually to bypass makes it very unusual and will cause maintainers to think twice before doing so. on the other hand, having automated bypassing process concerns me much more.

Agree with @nirrozenbaum completely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants