Skip to content

Commit

Permalink
Update _index.md MASTER_ADDR
Browse files Browse the repository at this point in the history
  • Loading branch information
@song-william
song-william authored Jun 14, 2024
1 parent 938519f commit b82e90b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion site/content/en/docs/concepts/_index.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ spec:
- containerPort: 3389
env:
- name: MASTER_ADDR
value: "pytorch-workers-0-0.pytorch-workers"
value: "pytorch-workers-0-0.pytorch"
- name: MASTER_PORT
value: "3389"
command:
Expand Down

1 comment on commit b82e90b

@SebastianScherer88
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this section also need to be updated? it says the name <jobset_name>-<replicated_job_name> of the headless service is the same as the subdomain, but this change suggests that the subdomain is just <jobset_name>. tbh subdomains at the level of the replicated job make more sense than just one at the jobset level. could you clarify what exactly applies here?

image

Please sign in to comment.