-
Notifications
You must be signed in to change notification settings - Fork 1.6k
✨ (go/v4) : Improve Kind Integration: Ensure Custom Kind Binary is Used in E2E Tests #4618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (go/v4) : Improve Kind Integration: Ensure Custom Kind Binary is Used in E2E Tests #4618
Conversation
|
Hi @kersten. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
675981c to
7be37d9
Compare
7be37d9 to
51fe16f
Compare
f2a70e7 to
c294491
Compare
|
/ok-to-test |
|
@kersten: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@camilamacedo86 could you trigger the tests? |
camilamacedo86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kersten
I added some coments see that when we change the scaffolds done by the tool we should not use 🌱 ( for those cases we need to use ✨ - new features and enhancements OR 🐛 for bug fixes )
add support for using a custom kind binary by reading from the KIND environment variable. This allows flexibility in testing environments where a different kind binary might be needed. The default behavior remains unchanged, using "kind" if no environment variable is set.
c294491 to
651ce94
Compare
|
/ok-to-test |
|
I checked this one again 👍 /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, kersten The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR refines the existing Kind integration by ensuring that the
KINDenvironment variable is consistently used across e2e test utilities. While PR #4615 made the Kind binary configurable in the Makefile, some test scripts and utilities still relied on the default"kind"binary directly. This change ensures that all test components respect theKINDvariable.Motivation
kindglobally available in$PATH.Changes
test/utils/utils.go) to check for aKINDenvironment variable before defaulting to"kind".KIND=$(KIND)togo test.Notes
kindifKINDis not set).