Skip to content

🐛 (revert) only changes done in the default scaffold in the pr: 4932 ( kept helm chart changes ) #5023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025
Merged

🐛 (revert) only changes done in the default scaffold in the pr: 4932 ( kept helm chart changes ) #5023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/book/src/cronjob-tutorial/testdata/project/config/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ spec:
- --leader-elect
- --health-probe-bind-address=:8081
image: controller:latest
imagePullPolicy: IfNotPresent
Copy link
Member Author

@camilamacedo86 camilamacedo86 Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adarshagrawal38

Hey I'm going to revert the changes in the default scaffold, and here's why.

I know I suggested this earlier, but after thinking it through, I realized it's not the best option. Changes to the stable default scaffold can't be done lightly because they can cause a lot of issues for users when they upgrade.

Adding all possible values and defaults would also make things very complex and hard, and bring confusion, seems like an anti pattern.

Ultimately, we need a better, more maintainable approach for our Helm charts plugin. See these links for more context:

I haven't had time to think of a solution, but I want to avoid making a change that creates more work for our users when they upgrade. If you have time, please feel free to look at these requirements and think about how we could address them in a better way.

Again, thank you so much for your contribution. I really appreciate your help.

name: manager
ports: []
securityContext:
Expand Down
1 change: 0 additions & 1 deletion docs/book/src/cronjob-tutorial/testdata/project/dist/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4213,7 +4213,6 @@ spec:
command:
- /manager
image: controller:latest
imagePullPolicy: IfNotPresent
livenessProbe:
httpGet:
path: /healthz
Expand Down
1 change: 0 additions & 1 deletion docs/book/src/getting-started/testdata/project/config/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ spec:
- --leader-elect
- --health-probe-bind-address=:8081
image: controller:latest
imagePullPolicy: IfNotPresent
name: manager
ports: []
securityContext:
Expand Down
1 change: 0 additions & 1 deletion docs/book/src/getting-started/testdata/project/dist/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,6 @@ spec:
command:
- /manager
image: controller:latest
imagePullPolicy: IfNotPresent
livenessProbe:
httpGet:
path: /healthz
Expand Down
1 change: 0 additions & 1 deletion docs/book/src/multiversion-tutorial/testdata/project/config/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ spec:
- --leader-elect
- --health-probe-bind-address=:8081
image: controller:latest
imagePullPolicy: IfNotPresent
name: manager
ports: []
securityContext:
Expand Down
1 change: 0 additions & 1 deletion docs/book/src/multiversion-tutorial/testdata/project/dist/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8110,7 +8110,6 @@ spec:
command:
- /manager
image: controller:latest
imagePullPolicy: IfNotPresent
livenessProbe:
httpGet:
path: /healthz
Expand Down
1 change: 0 additions & 1 deletion pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/manager/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ spec:
- --leader-elect
- --health-probe-bind-address=:8081
image: {{ .Image }}
imagePullPolicy: IfNotPresent
name: manager
ports: []
securityContext:
Expand Down
1 change: 0 additions & 1 deletion testdata/project-v4-multigroup/config/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ spec:
- --leader-elect
- --health-probe-bind-address=:8081
image: controller:latest
imagePullPolicy: IfNotPresent
name: manager
env:
- name: BUSYBOX_IMAGE
Expand Down
1 change: 0 additions & 1 deletion testdata/project-v4-multigroup/dist/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2947,7 +2947,6 @@ spec:
- name: MEMCACHED_IMAGE
value: memcached:1.6.26-alpine3.19
image: controller:latest
imagePullPolicy: IfNotPresent
livenessProbe:
httpGet:
path: /healthz
Expand Down
1 change: 0 additions & 1 deletion testdata/project-v4-with-plugins/config/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ spec:
- --leader-elect
- --health-probe-bind-address=:8081
image: controller:latest
imagePullPolicy: IfNotPresent
name: manager
env:
- name: BUSYBOX_IMAGE
Expand Down
1 change: 0 additions & 1 deletion testdata/project-v4-with-plugins/dist/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,7 +992,6 @@ spec:
- name: MEMCACHED_IMAGE
value: memcached:1.6.26-alpine3.19
image: controller:latest
imagePullPolicy: IfNotPresent
livenessProbe:
httpGet:
path: /healthz
Expand Down
1 change: 0 additions & 1 deletion testdata/project-v4/config/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ spec:
- --leader-elect
- --health-probe-bind-address=:8081
image: controller:latest
imagePullPolicy: IfNotPresent
name: manager
ports: []
securityContext:
Expand Down
1 change: 0 additions & 1 deletion testdata/project-v4/dist/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,7 +975,6 @@ spec:
command:
- /manager
image: controller:latest
imagePullPolicy: IfNotPresent
livenessProbe:
httpGet:
path: /healthz
Expand Down
Loading