Skip to content

WIP 🌱 (fix): linter check for YAML should consider files with sufix .yml as .yaml #5030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

WIP 🌱 (fix): linter check for YAML should consider files with sufix .yml as .yaml #5030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ lint-config: golangci-lint ## Verify golangci-lint linter configuration

.PHONY: yamllint
yamllint:
@files=$$(find testdata -name '*.yaml' ! -path 'testdata/*/dist/*'); \
@files=$$(find testdata -name '*.yaml' -o -name '*.yml' ! -path 'testdata/*/dist/*'); \
Copy link
Contributor

@vitorfloriano vitorfloriano Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @camilamacedo86 I was testing this patch and got a lot of errors in the dist directory. Perhaps the path is not being excluded properly?

docker run --rm $$(tty -s && echo "-it" || echo) -v $(PWD):/data cytopia/yamllint:latest $$files -d "{extends: relaxed, rules: {line-length: {max: 120}}}" --no-warnings

.PHONY: golangci-lint
Expand Down
Loading