Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update load balancers Versions and use the alpine base image #9100

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Update load balancers Versions and use the alpine base image #9100

merged 1 commit into from
Jul 19, 2022

Conversation

yankay
Copy link
Member

@yankay yankay commented Jul 18, 2022

Update load balancers Versions and use the alpine base image.

The nginx image 1.21.4 has so many CVEs. like : https://snyk.io/test/docker/nginx%3A1.21.4 .
So should we upgrade it to the newer version , and use the smaller base image ?

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Upgrade the nginx-proxy and haproxy image version , and use the alpine base image

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 18, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @yankay. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2022
@yankay
Copy link
Member Author

yankay commented Jul 19, 2022

Because Of the docker hub limit rate, we should upload an image to the quay.io to fix the issue.

#8364

@floryut
Copy link
Member

floryut commented Jul 19, 2022

Because Of the docker hub limit rate, we should upload an image to the quay.io to fix the issue.

#8364

nginx image is pushed to quay 👍

floryut
floryut approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
@yankay thanks by the way 😅

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2022
@yankay
Copy link
Member Author

yankay commented Jul 19, 2022

Because Of the docker hub limit rate, we should upload an image to the quay.io to fix the issue.
#8364

nginx image is pushed to quay 👍

Thank you very much

@cristicalin
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2a28271 into kubernetes-sigs:master Jul 19, 2022
@yankay
Copy link
Member Author

yankay commented Jul 20, 2022

Thanks @floryut @cristicalin , for the PR review

@yankay yankay mentioned this pull request Jul 22, 2022
Closed
9 tasks
@floryut floryut mentioned this pull request Sep 19, 2022
Closed
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@yankay @nolimitkun
update-loadbalancers-versions (kubernetes-sigs#9100)
6b501f3
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 2, 2023
@yankay @LuckySB
update-loadbalancers-versions (kubernetes-sigs#9100)
91bdac6
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
@yankay @LuckySB
update-loadbalancers-versions (kubernetes-sigs#9100)
732fd4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@jayonlau jayonlau Awaiting requested review from jayonlau

Assignees

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yankay @k8s-ci-robot @floryut @cristicalin