Skip to content

Commit

Permalink
Graduate LendingLimit to Beta
Browse files Browse the repository at this point in the history
  • Loading branch information
macsko committed Aug 27, 2024
1 parent c257cc0 commit b6ee6ab
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
3 changes: 1 addition & 2 deletions apis/kueue/v1beta1/clusterqueue_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,7 @@ type ResourceQuota struct {
// all the nominalQuota can be borrowed by other clusterQueues in the cohort.
// If not null, it must be non-negative.
// lendingLimit must be null if spec.cohort is empty.
// This field is in alpha stage. To be able to use this field,
// enable the feature gate LendingLimit, which is disabled by default.
// This field is in beta stage and is enabled by default.
// +optional
LendingLimit *resource.Quantity `json:"lendingLimit,omitempty"`
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/features/kube_features.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ const (
// owners: @B1F030, @kerthcet
// kep: https://github.com/kubernetes-sigs/kueue/tree/main/keps/1224-lending-limit
// alpha: v0.6
// beta: v0.9
//
// Enables lending limit.
LendingLimit featuregate.Feature = "LendingLimit"
Expand Down Expand Up @@ -118,7 +119,7 @@ var defaultFeatureGates = map[featuregate.Feature]featuregate.FeatureSpec{
VisibilityOnDemand: {Default: false, PreRelease: featuregate.Alpha},
PrioritySortingWithinCohort: {Default: true, PreRelease: featuregate.Beta},
MultiKueue: {Default: false, PreRelease: featuregate.Alpha},
LendingLimit: {Default: false, PreRelease: featuregate.Alpha},
LendingLimit: {Default: true, PreRelease: featuregate.Beta},
MultiKueueBatchJobWithManagedBy: {Default: false, PreRelease: featuregate.Alpha},
MultiplePreemptions: {Default: true, PreRelease: featuregate.Beta},
}
Expand Down
6 changes: 3 additions & 3 deletions site/content/en/docs/concepts/cluster_queue.md
Original file line number Diff line number Diff line change
Expand Up @@ -358,12 +358,12 @@ To limit the amount of resources that a ClusterQueue can lend in the cohort,
you can set the `.spec.resourcesGroup[*].flavors[*].resource[*].lendingLimit`
[quantity](https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/quantity/) field.

{{< feature-state state="alpha" for_version="v0.6" >}}
{{< feature-state state="beta" for_version="v0.9" >}}
{{% alert title="Warning" color="warning" %}}

`LendingLimit` is an Alpha feature disabled by default.
`LendingLimit` is a Beta feature enabled by default.

You can enable it by setting the `LendingLimit` feature gate. Check the [Installation](/docs/installation/#change-the-feature-gates-configuration) guide for details on feature gate configuration.
You can disable it by setting the `LendingLimit` feature gate. Check the [Installation](/docs/installation/#change-the-feature-gates-configuration) guide for details on feature gate configuration.
{{% /alert %}}

As an example, assume you created the following two ClusterQueues:
Expand Down
3 changes: 2 additions & 1 deletion site/content/en/docs/installation/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,8 @@ The currently supported features are:
| `QueueVisibility` | `false` | Alpha | 0.5 | |
| `VisibilityOnDemand` | `false` | Alpha | 0.6 | |
| `PrioritySortingWithinCohort` | `true` | Beta | 0.6 | |
| `LendingLimit` | `false` | Alpha | 0.6 | |
| `LendingLimit` | `false` | Alpha | 0.6 | 0.8 |
| `LendingLimit` | `true` | Beta | 0.9 | |
| `MultiplePreemptions` | `false` | Alpha | 0.8 | 0.8 |
| `MultiplePreemptions` | `true` | Beta | 0.9 | |

Expand Down
3 changes: 1 addition & 2 deletions site/content/en/docs/reference/kueue.v1beta1.md
Original file line number Diff line number Diff line change
Expand Up @@ -1787,8 +1787,7 @@ If null, it means that there is no lending limit, meaning that
all the nominalQuota can be borrowed by other clusterQueues in the cohort.
If not null, it must be non-negative.
lendingLimit must be null if spec.cohort is empty.
This field is in alpha stage. To be able to use this field,
enable the feature gate LendingLimit, which is disabled by default.</p>
This field is in beta stage and is enabled by default.</p>
</td>
</tr>
</tbody>
Expand Down

0 comments on commit b6ee6ab

Please sign in to comment.