From e6801eb81fe54e449b779ad3f33a85f7813aded9 Mon Sep 17 00:00:00 2001 From: Aldo Culquicondor Date: Wed, 23 Nov 2022 15:58:38 -0500 Subject: [PATCH] rename FromLowerPriority to LowerPriorityOnly Change-Id: I2060fee01e5618c2d452846ecbe18581e232e4ec --- keps/83-workload-preemption/README.md | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/keps/83-workload-preemption/README.md b/keps/83-workload-preemption/README.md index e2472dfc0a..c771b2b239 100644 --- a/keps/83-workload-preemption/README.md +++ b/keps/83-workload-preemption/README.md @@ -106,7 +106,7 @@ metadata: spec: preemption: withinCohort: Always - withinClusterQueue: FromLowerPriority + withinClusterQueue: LowerPriorityOnly ``` ### Notes/Contraints/Caveats (Optional) @@ -211,30 +211,30 @@ type ClusterQueueSpec struct { type PreemptionPolicy string const ( - PreemptionPoliyNever = "Never" - PreemptionPoliyFromLowerPriority = "FromLowerPriority" - PreemptionPoliyAlways = "Always" + PreemptionPoliyNever = "Never" + PreemptionPoliyLowerPriorityOnly = "LowerPriorityOnly" + PreemptionPoliyAlways = "Always" ) type ClusterQueuePreemption struct { - // reclaimBorrowedQuota determines whether a pending Workloas, that fits + // withinCohort determines whether a pending Workload, that fits // in the min quota for its ClusterQueue, can preempt Workloads from other // ClusterQueues in the cohort that are using more than their min quota. // Possible values are: // - `Never` (default): do not preempt workloads in the cohort. - // - `FromLowerPriority`: only preempt workloads in the cohort that have lower + // - `LowerPriorityOnly`: only preempt workloads in the cohort that have lower // priority than the pending Workload. // - `Always`: preempt any workload in the cohort. - withinCohort *PreemptionPolicy + WithinCohort PreemptionPolicy // withinClusterQueue determines whether a pending workload that doesn't fit // within the min quota for its ClusterQueue, can preempt active Workloads in // the ClusterQueue. // Possible values are: // - `Never` (default): do not preempt workloads in the ClusterQueue. - // - `FromLowerPriority`: only preempt workloads in the ClusterQueue that have - // lower priority than the pendingWorkload. - withinClusterQueue *PreemptionPolicy + // - `LowerPriorityOnly`: only preempt workloads in the ClusterQueue that have + // lower priority than the pendingWorkload. + WithinClusterQueue PreemptionPolicy } ``` @@ -338,7 +338,7 @@ The algorithm goes like follows: 1. For preemption within cohort, we restrict the list to Workloads with lower priority than the pending Workload if - `.preemption.withinCohort=FromLowerPriority` + `.preemption.withinCohort=LowerPriorityOnly` 2. For preemption within ClusterQueue, we only select Workloads with lower priority than the pending Workload.