Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change make cluster queue in wrappers to bestfifo #227

Merged
merged 1 commit into from
May 1, 2022
Merged

Change make cluster queue in wrappers to bestfifo #227

merged 1 commit into from
May 1, 2022

Conversation

denkensk
Copy link
Member

Signed-off-by: Alex Wang wangqingcan1990@gmail.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

#179 (comment)_

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 21, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 21, 2022
@denkensk
Copy link
Member Author

/assign @ahg-g

@denkensk
Copy link
Member Author

/test pull-kueue-test-integration-main

ahg-g
ahg-g reviewed Apr 25, 2022
View reviewed changes
Copy link
Contributor

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add a test dedicated for StrictFIFO?

test/integration/scheduler/scheduler_test.go Show resolved Hide resolved
@alculquicondor
Copy link
Contributor

I will leave this one to @ahg-g

@denkensk denkensk mentioned this pull request Apr 29, 2022
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2022
@denkensk
Copy link
Member Author

denkensk commented Apr 30, 2022 •
edited
Loading

Can you please also add a test dedicated for StrictFIFO?

Added @ahg-g

ahg-g
ahg-g reviewed Apr 30, 2022
View reviewed changes
test/integration/scheduler/scheduler_test.go Outdated Show resolved Hide resolved
test/integration/scheduler/scheduler_test.go Outdated Show resolved Hide resolved
test/integration/scheduler/scheduler_test.go Outdated Show resolved Hide resolved
@ahg-g
Copy link
Contributor

ahg-g commented May 1, 2022

please squash.

@denkensk
Change make clusterqueue in wrappers to bestfifo
5ce7596 
Signed-off-by: Alex Wang <wangqingcan1990@gmail.com>
@denkensk
Copy link
Member Author

denkensk commented May 1, 2022

/test pull-kueue-test-integration-main

@denkensk
Copy link
Member Author

denkensk commented May 1, 2022

please squash.

Done. @ahg-g

@ahg-g
Copy link
Contributor

ahg-g commented May 1, 2022

/test pull-kueue-test-integration-main

We shouldn't dismiss any failed run, if it was a new flake, we need to fix it. We shouldn't just keep retrying the test, this is not k8s repo :)

@ahg-g
Copy link
Contributor

ahg-g commented May 1, 2022

/test pull-kueue-test-integration-main

We shouldn't dismiss any failed run, if it was a new flake, we need to fix it. We shouldn't just keep retrying the test, this is not k8s repo :)

Created #241; I think this flake discovered a potential bug.

@ahg-g
Copy link
Contributor

ahg-g commented May 1, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, denkensk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 26f4ac4 into kubernetes-sigs:main May 1, 2022
@denkensk
Copy link
Member Author

denkensk commented May 1, 2022

Created #241; I think this flake discovered a potential bug.

Thanks. I tested it a lot on my own computer and did not reproduce it. But in CI test there is a chance that it will fail.

@alculquicondor
Copy link
Contributor

Is the new flake only showing up after this PR?

@ahg-g
Copy link
Contributor

ahg-g commented May 2, 2022

It was on this PR, but this PR only changes the tests, so the flake is very likely unrelated to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denkensk @alculquicondor @ahg-g @k8s-ci-robot