Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Note instead Warning on the LendingLimit is enabled by default info. #3010

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

mbobrovskyi
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Use Note instead Warning on the LendingLimit is enabled by default info.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 6, 2024
@mbobrovskyi
Copy link
Contributor Author

/cc @alculquicondor

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit b03cf97
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66db23ee82e35b00086ded32
😎 Deploy Preview https://deploy-preview-3010--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 6, 2024
@alculquicondor
Copy link
Contributor

/lgtm
/approve
/cherry-pick website

@k8s-infra-cherrypick-robot
Copy link
Contributor

@alculquicondor: once the present PR merges, I will cherry-pick it on top of website in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/cherry-pick website

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3f612d0687bc94cf734d5da93c4c17443a956553

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mbobrovskyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7fed123 into kubernetes-sigs:main Sep 6, 2024
7 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Sep 6, 2024
@k8s-infra-cherrypick-robot
Copy link
Contributor

@alculquicondor: #3010 failed to apply on top of branch "website":

Applying: Use Note instead Warning on the LendingLimit is enabled by default info.
Using index info to reconstruct a base tree...
M	site/content/en/docs/concepts/cluster_queue.md
Falling back to patching base and 3-way merge...
Auto-merging site/content/en/docs/concepts/cluster_queue.md
CONFLICT (content): Merge conflict in site/content/en/docs/concepts/cluster_queue.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Use Note instead Warning on the LendingLimit is enabled by default info.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/lgtm
/approve
/cherry-pick website

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mbobrovskyi mbobrovskyi deleted the docs/set-primary-color branch September 6, 2024 16:09
@mbobrovskyi
Copy link
Contributor Author

@alculquicondor ah, it's not cherry-picked yet #2909.

@alculquicondor
Copy link
Contributor

True. Let's leave it like this

kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants