Make LossLessDefaulter selective to only prevent dropping fields outside of schema

[mbobrovskyi]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Make LossLessDefaulter selective to only prevent dropping fields outside of schema.

Which issue(s) this PR fixes:

Fixes #3174

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbobrovskyi
Once this PR has been reviewed and has the lgtm label, please assign kerthcet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/controller/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	fd80f06
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/671ba002144b1b0008a10ce4

[mbobrovskyi]

/cc @mimowo

[mbobrovskyi]

/retest

[alculquicondor]

so this is matching kubernetes-sigs/controller-runtime#2982, right?

[mbobrovskyi]

so this is matching kubernetes-sigs/controller-runtime#2982, right?

Yes, I created a PR here to fix it in Kueue. After kubernetes-sigs/controller-runtime#2982 is merged, we can remove it here.

[mimowo]

Yes, and we also did it to check all the tests we developed testing other solutions pass with this approach - to gain more confidence in it.

Indeed, if the fix is merged for controller-runtime I think we don't need to merge it in kueue.

[alculquicondor]

That will take time to trickle. OTOH, the current solution works for all of our webhooks today.

[mbobrovskyi]

/hold

Looks like kubernetes-sigs/controller-runtime#2982 almost done.

[trasc]

/hold

Looks like kubernetes-sigs/controller-runtime#2982 almost done.

Even if it gets merged, it will take some time for it be part of a release and for kueue to use that release.

[mimowo]

I think we have time to wait for now, because the current solution works fine as long as the webhooks don't remove fields.
So I would suggest to close this PR for now. We can re-open if we have a pressing need to allow for removing fields by Kueue webhooks, but for now it seems we can wait.

I opened #3469 to track it.

[mbobrovskyi]

/close

[k8s-ci-robot]

@mbobrovskyi: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.