Implement genericjob interface on batchv1.Job

[kerthcet]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

xref: #369

Special notes for your reviewer:

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kerthcet
Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval by writing /assign @ahg-g in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mimowo]

For a heads up, I'm starting the support for the MPIJob: #578. For now, I'm not using the interface, but continuing by copy-paste. We may abstract these two implementations once the MPIJob is done. Alternatively, if the interface is merged first I will rebase to use it and potentially adapt to the MPI needs.

FYI: @mwielgus @alculquicondor

[kerthcet]

For a heads up, I'm starting the support for the MPIJob: #578. For now, I'm not using the interface, but continuing by copy-paste. We may abstract these two implementations once the MPIJob is done. Alternatively, if the interface is merged first I will rebase to use it and potentially adapt to the MPI needs.

FYI: @mwielgus @alculquicondor

One thing to mention about is #537 (comment), I'd like to provide a full controller, then all you need to do is just implement the Job Interface, do you think this can work well?

[mimowo]

One thing to mention about is #537 (comment), I'd like to provide a full controller, then all you need to do is just implement the Job Interface, do you think this can work well?

I guess it could be helpful if the interface is abstracted well enough. We need to abstract it anyway at some point.

If the interface is merged first I may need to adapt it a little bit, but it will be helpful, if the MPI integration is merged first, then we may need to adapt the interface. I think we just continue the efforts and see how we synchronize. When I have a working prototype I may also give you some comments to the interface. WDYT @alculquicondor ?

[alculquicondor]

+1

[k8s-ci-robot]

@kerthcet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kueue-test-e2e-main-1-25	ebf2b81	link	true	/test pull-kueue-test-e2e-main-1-25
pull-kueue-test-e2e-main-1-26	ebf2b81	link	true	/test pull-kueue-test-e2e-main-1-26

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[alculquicondor]

/close

Superseded by #616

[k8s-ci-robot]

@alculquicondor: Closed this PR.

In response to this:

/close

Superseded by #616

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.