Reorganize directory structure for jobs and the framework #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
the
size/M
|
/assign @alculquicondor @kerthcet |
Comment on lines
+50
to
+51
| "sigs.k8s.io/kueue/pkg/controller/jobs/job" | ||
| "sigs.k8s.io/kueue/pkg/controller/jobs/mpijob" |
There was a problem hiding this comment.
once mpijob goes into another module:
Suggested change
| "sigs.k8s.io/kueue/pkg/controller/jobs/job" | |
| "sigs.k8s.io/kueue/pkg/controller/jobs/mpijob" | |
| "sigs.k8s.io/kueue/pkg/controller/job" |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The current directory structure has been contested as problematic: #578 (comment).
One issue is that the framwork and the jobs are under workload directory, which is misleading in this case as it is ambiguous (generalization of a batch workload, or a specific concept in Kueue).
Another issue is that the jobframework library is at the same level in hierarchy as jobs of particular frameworks.
Which issue(s) this PR fixes:
Part of #369
Special notes for your reviewer:
As a starting point organize according to the proposal: #627 (comment).