UX: SourceRef should be default-expanded in Notebooks? #5866
Comments
|
not expanded:
|
|
Expanded: |
|
If we do this, we probably want to finagle SimpleEditor so that it is sized to fit, in terms of height. For this, we can use the relatively new (introduced in 0.20.x) |
starpit
added a commit
to starpit/kui
that referenced
this issue
Oct 6, 2020
…ded in Notebooks? This PR updates SimpleEditor so that, for `simple` props, it is sized to fit, in terms of height. Fixes kubernetes-sigs#5866
7 tasks
starpit
added a commit
to starpit/kui
that referenced
this issue
Oct 6, 2020
…ded in Notebooks? This PR updates SimpleEditor so that, for `simple` props, it is sized to fit, in terms of height. Fixes kubernetes-sigs#5866
starpit
added a commit
to starpit/kui
that referenced
this issue
Oct 6, 2020
…ded in Notebooks? This PR updates SimpleEditor so that, for `simple` props, it is sized to fit, in terms of height. This PR also fixes a longer-standing problem where reducing the width of the window would not result in a re-layout of monaco for SourceRef; we need a min-width: 0 on flex-fill Fixes kubernetes-sigs#5866
starpit
added a commit
to starpit/kui
that referenced
this issue
Oct 6, 2020
…ded in Notebooks? This PR updates SimpleEditor so that, for `simple` props, it is sized to fit, in terms of height. This PR also fixes a longer-standing problem where reducing the width of the window would not result in a re-layout of monaco for SourceRef; we need a min-width: 0 on flex-fill Fixes kubernetes-sigs#5866
starpit
added a commit
to starpit/kui
that referenced
this issue
Oct 6, 2020
…ded in Notebooks? This PR updates SimpleEditor so that, for `simple` props, it is sized to fit, in terms of height. This PR also fixes a longer-standing problem where reducing the width of the window would not result in a re-layout of monaco for SourceRef; we need a min-width: 0 on flex-fill Fixes kubernetes-sigs#5866
starpit
added a commit
that referenced
this issue
Oct 6, 2020
…ded in Notebooks? This PR updates SimpleEditor so that, for `simple` props, it is sized to fit, in terms of height. This PR also fixes a longer-standing problem where reducing the width of the window would not result in a re-layout of monaco for SourceRef; we need a min-width: 0 on flex-fill Fixes #5866
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The suggestion here is that, when viewing a Notebook, the referenced Source (e.g. the foo.yaml in
kubectl apply -f foo.yaml) is an important part of the educational potential of the Notebook.The text was updated successfully, but these errors were encountered: